Picked up <limits> include bugfix in url-cpp to address compile errors on newer platforms #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change picks up the missing
#include <limits>from the upstream:seomoz/url-cpp@5cf7ecc (note that some additional non-functional changes are included).
This is intended to at least partially address the downstream issue: seomoz/reppy#132
Ultimately, this is a case where we're not "including what we use". The fact that this works currently is by luck - one of the other included libraries also includes the headers we're looking for.
Tests pass, although installing
gcovrinto the Vagrant environment is broken on master branch, so no coverage is generated.We could be more strict about setting up tests and so forth, but to avoid scope creep on a project that's not actively maintained, I'm going to go ahead and call this one safe, and merge (after internal discussion with other folks at Moz, of course).