Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: document replication factor and persistence size for future enhancements #1505

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

patsevanton
Copy link
Contributor

@patsevanton patsevanton commented Oct 3, 2024

This pull request adds comments to the values.yaml file for the Kafka configuration, specifically focusing on the replicationFactor and persistence.size settings. These comments are intended to guide future enhancements and provide context for potential adjustments to improve data reliability and fault tolerance in Kafka deployments.

Changes:

  • Added a comment explaining the purpose of increasing the replicationFactor to enhance data reliability during Kafka pod failures.
  • Added a comment suggesting an increase in persistence.size if the load on the Kafka controller increases.

Comments:

  • replicationFactor: "Increasing the replicationFactor enhances data reliability during Kafka pod failures by replicating data across multiple brokers."
  • persistence.size: "If the load on the Kafka controller increases, persistence.size must be increased."

Related Issues:

These comments will help maintainers and developers understand the rationale behind future changes and ensure that Kafka configurations remain robust and reliable.

@Mokto Mokto merged commit 480d943 into sentry-kubernetes:develop Oct 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants