feat: improve cover selection algorithm #516
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Gonic is a fantastic project for local music streaming. However, I noticed that Gonic doesn't recognize some album covers. After digging into the code, I found that cover art can only be recognized if it follows certain fixed patterns. Most of my albums are downloaded from BitTorrent, so the naming of cover art varies. Here is a sample file list created by running
find /data/ | grep -i -E '.png|.jpg|.jpeg|.webp|.gif '
:files.txt
To address this issue, I propose a simple but more effective way to select cover art from an album. Please check the code for details.
A docker images built on this PR is available:
docker.io/heimoshuiyu/gonic:cover