style: remove unused nolint and make some file level ones specific

sentriz · Mar 6, 2024 · 1a287ce · 1a287ce
1 parent b533ab7
commit 1a287ce
Show file tree

Hide file tree

Showing 7 changed files with 11 additions and 11 deletions.
diff --git a/db/migrations.go b/db/migrations.go
@@ -1,4 +1,3 @@
-//nolint:goerr113
 package db
 
 import (

diff --git a/infocache/albuminfocache/albuminfocache.go b/infocache/albuminfocache/albuminfocache.go
@@ -1,4 +1,3 @@
-//nolint:revive
 package albuminfocache
 
 import (

diff --git a/infocache/artistinfocache/artistinfocache.go b/infocache/artistinfocache/artistinfocache.go
@@ -1,4 +1,3 @@
-//nolint:revive
 package artistinfocache
 
 import (

diff --git a/scanner/scanner.go b/scanner/scanner.go
@@ -1,4 +1,3 @@
-//nolint:nestif
 package scanner
 
 import (
@@ -328,7 +327,7 @@ func (s *Scanner) populateTrackAndArtists(tx *db.DB, st *State, i int, album *db
 	}
 
 	// metadata for the album table comes only from the first track's tags
-	if i == 0 {
+	if i == 0 { //nolint:nestif
 		if err := tx.Where("album_id=?", album.ID).Delete(db.ArtistAppearances{}).Error; err != nil {
 			return fmt.Errorf("delete artist appearances: %w", err)
 		}

diff --git a/server/ctrladmin/handlers.go b/server/ctrladmin/handlers.go
@@ -1,4 +1,3 @@
-//nolint:goerr113
 package ctrladmin
 
 import (

diff --git a/transcode/transcode.go b/transcode/transcode.go
@@ -1,7 +1,6 @@
 // author: spijet (https://github.com/spijet/)
 // author: sentriz (https://github.com/sentriz/)
 
-//nolint:gochecknoglobals
 package transcode
 
 import (
@@ -18,6 +17,7 @@ type Transcoder interface {
 	Transcode(ctx context.Context, profile Profile, in string, out io.Writer) error
 }
 
+//nolint:gochecknoglobals
 var UserProfiles = map[string]Profile{
 	"mp3":          MP3,
 	"mp3_320":      MP3320,
@@ -32,6 +32,8 @@ var UserProfiles = map[string]Profile{
 }
 
 // Store as simple strings, since we may let the user provide their own profiles soon
+//
+//nolint:gochecknoglobals
 var (
 	MP3    = NewProfile("audio/mpeg", "mp3", 128, `ffmpeg -v 0 -i <file> -ss <seek> -map 0:a:0 -vn -b:a <bitrate> -c:a libmp3lame -f mp3 -`)
 	MP3320 = NewProfile("audio/mpeg", "mp3", 320, `ffmpeg -v 0 -i <file> -ss <seek> -map 0:a:0 -vn -b:a <bitrate> -c:a libmp3lame -f mp3 -`)

diff --git a/version.go b/version.go
@@ -1,14 +1,17 @@
-//nolint:gochecknoglobals,golint,stylecheck
 package gonic
 
 import (
 	_ "embed"
 	"strings"
 )
 
-//go:embed version.txt
-var version string
-var Version = strings.TrimSpace(version)
+//nolint:gochecknoglobals
+var (
+	//go:embed version.txt
+	version string
+
+	Version = strings.TrimSpace(version)
+)
 
 const (
 	Name      = "gonic"