Apply Powershell Import comments #18

Please refer to https://github.com/bbatsov/ruby-style-guide

More cosmetic fixes for enum_services

…y File Upload

As of PHP 5.5.0, unpack("a", ...) no longer strips the NULL byte from the end of the string. A new format specifier, Z, was introduced to perform the old behavior, but we don't have a good way to test for its existence. Instead, just remove it with str_replace

This was previously left dangling, which leaves the port open, but doesn't do anything with subsequent connections.

…eter

@OJ

This incoporates @OJ's fixes as a result of gemification.

Correct casing in the title Anchor the use of ::File Force body.to_s since it can be nil in corner cases

Various values were adjusted to become QWORD values in MSF an windows meterpreter, but the changes were not ported over to python, php and java. This commit fixes this inconsistency.

Four modules updated for the weekly release with minor cosmetic fixes. - [ ] See all affected modules still load. - [ ] See all affected modules have expected `info`

Release fixup: Description/whitespace changes (minor)

… into dlink_upnp_msearch_command_injection

Conflicts: Gemfile.lock

Fix table printing.

May affect the following RM issues which need to be retested: https://dev.metasploit.com/redmine/issues/8407 https://dev.metasploit.com/redmine/issues/4314 https://dev.metasploit.com/redmine/issues/6829

…Injection

…oauth

…014-3936

Just a suggestion. I always personally modify this. I use it to scrape titles often, and i prefer it to be saved in notes rather than wmap results, because i find it easier to search and automatically add results to rhosts.

Seems that only one header line gets added to host notes, and the rest are thrown away. This adds the counter number to the type string, so that each header line entry is unique and correctly saved. I also added port in case you want headers from several ports on one host without the previous getting overwritten. (scanning shodanhq.com) ----BEFORE---- msf auxiliary(http_header) > run -j [*] Auxiliary module running as background job msf auxiliary(http_header) > [*] 162.159.245.38:80: requesting / via HEAD [*] 162.159.245.38:80: deleted header Expires [*] 162.159.245.38:80: CF-RAY: 1485d013ca880773-EWR [*] 162.159.245.38:80: CACHE-CONTROL: max-age=15 [*] 162.159.245.38:80: CONNECTION: keep-alive [*] 162.159.245.38:80: CONTENT-TYPE: text/html; charset=UTF-8 [*] 162.159.245.38:80: DATE: Fri, 11 Jul 2014 14:50:20 GMT [*] 162.159.245.38:80: SERVER: cloudflare-nginx [*] 162.159.245.38:80: SET-COOKIE: __cfduid=d3914e07fc681306bb53129adb3e6b1d41405090220122; expires=Mon, 23-Dec-2019 23:50:00 GMT; path=/; HttpOnly [+] 162.159.245.38:80: detected 7 headers [*] Scanned 1 of 1 hosts (100% complete) msf auxiliary(http_header) > notes [*] Time: 2014-07-11 14:50:19 UTC Note: host=162.159.245.38 type=HTTP header data="SET-COOKIE: __cfduid=d3914e07fc681306bb53129adb3e6b1d41405090220122; expires=Mon, 23-Dec-2019 23:50:00 GMT; path=/; HttpOnly" msf auxiliary(http_header) > ----AFTER---- msf auxiliary(http_header) > run -j [*] Auxiliary module running as background job msf auxiliary(http_header) > [*] 162.159.245.38:80: requesting / via HEAD [*] 162.159.245.38:80: CF-RAY: 14869ad5c0970f57-FRA [*] 162.159.245.38:80: CACHE-CONTROL: max-age=15 [*] 162.159.245.38:80: CONNECTION: keep-alive [*] 162.159.245.38:80: CONTENT-TYPE: text/html; charset=UTF-8 [*] 162.159.245.38:80: DATE: Fri, 11 Jul 2014 17:08:45 GMT [*] 162.159.245.38:80: EXPIRES: Fri, 11 Jul 2014 17:09:00 GMT [*] 162.159.245.38:80: SERVER: cloudflare-nginx [*] 162.159.245.38:80: SET-COOKIE: __cfduid=db2918126c4b49780b4669e88b72580521405098525082; expires=Mon, 23-Dec-2019 23:50:00 GMT; path=/; HttpOnly [+] 162.159.245.38:80: detected 8 headers [*] Scanned 1 of 1 hosts (100% complete) msf auxiliary(http_header) > notes [*] Time: 2014-07-11 17:08:44 UTC Note: host=162.159.245.38 type=http.80.header.0 data="CF-RAY: 14869ad5c0970f57-FRA" [*] Time: 2014-07-11 17:08:44 UTC Note: host=162.159.245.38 type=http.80.header.1 data="CACHE-CONTROL: max-age=15" [*] Time: 2014-07-11 17:08:44 UTC Note: host=162.159.245.38 type=http.80.header.2 data="CONNECTION: keep-alive" [*] Time: 2014-07-11 17:08:44 UTC Note: host=162.159.245.38 type=http.80.header.3 data="CONTENT-TYPE: text/html; charset=UTF-8" [*] Time: 2014-07-11 17:08:44 UTC Note: host=162.159.245.38 type=http.80.header.4 data="DATE: Fri, 11 Jul 2014 17:08:45 GMT" [*] Time: 2014-07-11 17:08:44 UTC Note: host=162.159.245.38 type=http.80.header.5 data="EXPIRES: Fri, 11 Jul 2014 17:09:00 GMT" [*] Time: 2014-07-11 17:08:44 UTC Note: host=162.159.245.38 type=http.80.header.6 data="SERVER: cloudflare-nginx" [*] Time: 2014-07-11 17:08:44 UTC Note: host=162.159.245.38 type=http.80.header.7 data="SET-COOKIE: __cfduid=db2918126c4b49780b4669e88b72580521405098525082; expires=Mon, 23-Dec-2019 23:50:00 GMT; path=/; HttpOnly" msf auxiliary(http_header) >

Fix up rapid7#3285 (very minor changes)

DbVisualizer stores the user database configuration in dbvis.xml. This module retrieves the connections settings from this file.

This module retrieves the connections settings from this file

I didn't misspell it this time. :)

This is an if condition, not an assignment

msfconsole treats whatever is in <> as the author's email, not twitter handle

We're already checking the file path with file?(), so we don't need to use exception handling for this task anymore.

Includes fixes for the sniffer which stop it breaking on x64 and make it work with the `any` interface. [FixRM rapid7#6355]

Changes ok

Checking for "config" folder existence if "config70" is not found.

Added functions to parse old and new config files.

The HACKING file still uses the old link, which redirects to this one, why not just use this one?

This is a work in progress because the code base is old and the style varies wildly, however .rubocop.yml can (and should) be tweaked over time to change standards as we see fit. As it stands right now there are few (if any) modules that pass Rubocop.

Dbvisulaizer offers a command line functionality to execute SQL pre-configured databases (With GUI). The remote database can be accessed from the command line without the need to authenticate. The module abuses this functionality to create an administrator in the database if DB user rights allow it.

@source

Fix @source and prefer &&

… class documentation requirement for modules and don't require big numbers like 12737341238 to be separated with _ -- who does that?

… direct violation of Penal Code 1.13, Section 9.

Corrections

Dbvisulaizer offers a command line functionality to execute SQL pre-configured databases (With GUI). The remote database can be accessed from the command line without the need to authenticate. The module abuses this functionality to query the remote database and store the result.

Minor changes

I like the change but it means that basically everything will fail forever until we tweak up the config.

Rubocop checks are optional and info only

This adds the gem to the :development group in the Gemfile, as well as wires up msftidy to use it.

Missed a commit.

INFO level messages should not block commits or be complained about on merges. They should merely inform the user.

The Gemfile was badly formatted anyway, since it lacked a justifying comment, as all other included gems have.

This looks good to me, the whole print statement is enclosed in a check for results.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Apply Powershell Import comments #18

Apply Powershell Import comments #18

Commits on Jul 2, 2014

Commits on Jul 3, 2014

Commits on Jul 4, 2014

Commits on Jul 5, 2014

Commits on Jul 6, 2014

Commits on Jul 7, 2014

Commits on Jul 8, 2014

Commits on Jul 9, 2014

Commits on Jul 10, 2014

Commits on Jul 11, 2014

Commits on Jul 13, 2014

Commits on Jul 14, 2014

Commits on Jul 15, 2014

Commits on Jul 16, 2014

Commits on Jul 17, 2014

Commits on Jul 18, 2014

Commits on Jul 19, 2014

Commits on Jul 20, 2014

Apply Powershell Import comments #18

Are you sure you want to change the base?

Apply Powershell Import comments #18

Commits on Jul 2, 2014

Commits on Jul 3, 2014

Commits on Jul 4, 2014

Commits on Jul 5, 2014

Commits on Jul 6, 2014

Commits on Jul 7, 2014

Commits on Jul 8, 2014

Commits on Jul 9, 2014

Commits on Jul 10, 2014

Commits on Jul 11, 2014

Commits on Jul 13, 2014

Commits on Jul 14, 2014

Commits on Jul 15, 2014

Commits on Jul 16, 2014

Commits on Jul 17, 2014

Commits on Jul 18, 2014

Commits on Jul 19, 2014

Commits on Jul 20, 2014