Fix C# regression in preprocessor directive parsing #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was due to a left-over syntax extension workaround that no longer applies and was causing conflicts.
mjambon
commented
Oct 10, 2024
| (expression_statement | ||
| (invocation_expression | ||
| (identifier) | ||
| (argument_list)))))))) |
aryx
approved these changes
Oct 10, 2024
Test 'Typed metavariable 3' was failing and was being parsed as binary '<' and '>' operations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was due to a left-over syntax extension workaround that no longer applies and was causing conflicts.
This also fixes incorrect parsing of typed metavariables where the type is parametrized. The problem occurred just now in Semgrep and didn't have a test for this specific case (e.g.
(List<T> $X)was parsed as(List < T) > $X).Integration work in progress at https://github.com/semgrep/semgrep-proprietary/pull/2390
Checklist