Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Move support for semgrep #500

Merged
merged 11 commits into from
Jul 29, 2024
Merged

Conversation

chargarlic
Copy link
Contributor

@chargarlic chargarlic commented Jul 25, 2024

Introduction of Move on Sui based on https://semgrep.dev/docs/contributing/adding-a-language . This is different frommove-on-aptos and targets a flavor of Move that is used by the Sui network.

@chargarlic chargarlic requested a review from a team as a code owner July 25, 2024 18:35
@chargarlic chargarlic requested review from ihji and brandonspark and removed request for a team July 25, 2024 18:35
@CLAassistant
Copy link

CLAassistant commented Jul 25, 2024

CLA assistant check
All committers have signed the CLA.

@ihji
Copy link
Contributor

ihji commented Jul 25, 2024

LGTM. Is the update to the tree-sitter-c-sharp submodule needed for this PR?

@aryx
Copy link
Collaborator

aryx commented Jul 26, 2024

yes please remove the change related to tree-sitter-csharp.

Copy link
Collaborator

@aryx aryx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the c# change.
Also could you sign the CLA and explain a little bit in the PR description
what is the difference between this Move and the Move on aptos we already have?
Should we rename it to move-on-sui?

@chargarlic
Copy link
Contributor Author

LGTM. Is the update to the tree-sitter-c-sharp submodule needed for this PR?

No it is not, i cleared it up and removed those now

@chargarlic
Copy link
Contributor Author

remove the c# change. Also could you sign the CLA and explain a little bit in the PR description what is the difference between this Move and the Move on aptos we already have? Should we rename it to move-on-sui?

There are feature and syntax differences, i can rename to move-on-sui

@chargarlic chargarlic force-pushed the chargarlic/add-support-move branch from 5701078 to 4f31e18 Compare July 26, 2024 17:16
@chargarlic chargarlic force-pushed the chargarlic/add-support-move branch from 10530cf to a3e88b0 Compare July 26, 2024 17:20
@chargarlic chargarlic requested a review from aryx July 26, 2024 17:24
@aryx aryx merged commit bf4715f into semgrep:main Jul 29, 2024
2 checks passed
Copy link
Collaborator

@aryx aryx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fixing this in another PR

const base_grammar = require('tree-sitter-move-on-sui/grammar');

module.exports = grammar(base_grammar, {
name: 'move',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needed to be move_on_sui, otherwise
./test-lang move-on-sui was failing with an OCaml linking error.

@aryx
Copy link
Collaborator

aryx commented Jul 29, 2024

Fix here: #501

@aryx
Copy link
Collaborator

aryx commented Jul 29, 2024

ok I've generated the code in https://github.com/semgrep/semgrep-move-on-sui

@aryx
Copy link
Collaborator

aryx commented Jul 29, 2024

now you need to add this repo as a submodule in the semgrep repo and start to add the language in semgrep-interface like the other person did for Move-on-aptos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants