-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Move support for semgrep #500
Conversation
LGTM. Is the update to the |
yes please remove the change related to tree-sitter-csharp. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove the c# change.
Also could you sign the CLA and explain a little bit in the PR description
what is the difference between this Move and the Move on aptos we already have?
Should we rename it to move-on-sui?
No it is not, i cleared it up and removed those now |
There are feature and syntax differences, i can rename to move-on-sui |
5701078
to
4f31e18
Compare
10530cf
to
a3e88b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fixing this in another PR
const base_grammar = require('tree-sitter-move-on-sui/grammar'); | ||
|
||
module.exports = grammar(base_grammar, { | ||
name: 'move', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this needed to be move_on_sui, otherwise
./test-lang move-on-sui was failing with an OCaml linking error.
Fix here: #501 |
ok I've generated the code in https://github.com/semgrep/semgrep-move-on-sui |
now you need to add this repo as a submodule in the semgrep repo and start to add the language in semgrep-interface like the other person did for Move-on-aptos. |
Introduction of Move on Sui based on https://semgrep.dev/docs/contributing/adding-a-language . This is different from
move-on-aptos
and targets a flavor of Move that is used by the Sui network.