Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elixir allows metavariables as keywords #467

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

amchiclet
Copy link
Contributor

Previously, keywords (as in keyword/value pairs) didn't allow metavariables, so cases like

  foo($KEYWORD: $VALUE)
  %{$KEYWORD: $VALUE}

would fail to parse.

This PR adds support for that.

Also made ellipsis its own rule, as previously suggested at #466.

Tested with make test and added a test.

Security

  • Change has no security implications (otherwise, ping the security team)

@amchiclet amchiclet force-pushed the amarin/elixir-metavar-keyvalue-pair branch 2 times, most recently from fdb2fd7 to 1ca3771 Compare January 16, 2024 21:43
@amchiclet
Copy link
Contributor Author

The workflow build-on-commit failed because some CircleCI thing that we need to fix.

But I ran the steps needed for that workflow locally and all tests passed.

@amchiclet amchiclet marked this pull request as ready for review January 16, 2024 23:08
@amchiclet amchiclet requested a review from a team as a code owner January 16, 2024 23:08
@amchiclet amchiclet removed the request for review from a team January 16, 2024 23:25
@amchiclet
Copy link
Contributor Author

The CircleCI is still failing (we haven't moved to GHA yet), so I ran the steps needed for that workflow locally and all tests passed.

Merging now.

Previously, keywords (as in keyword/value pairs) didn't allow
metavariables, so cases like
  foo($KEYWORD: $VALUE)
  %{$KEYWORD: $VALUE}
would fail to parse.

This PR adds support for that.

Tested with make test and added a test.
@amchiclet amchiclet force-pushed the amarin/elixir-metavar-keyvalue-pair branch from 5761237 to 0df80d8 Compare January 24, 2024 04:03
@amchiclet amchiclet merged commit 1f59784 into main Jan 24, 2024
2 of 3 checks passed
@amchiclet amchiclet deleted the amarin/elixir-metavar-keyvalue-pair branch January 24, 2024 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants