Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cli monorepo ethers and subgraph web app UI #841

Merged
merged 48 commits into from
Oct 21, 2024

Conversation

yagopajarino
Copy link
Contributor

@yagopajarino yagopajarino commented Jul 28, 2024

Description

Update cli template ethers and subgraph web app UI using boilerplate code from https://github.com/semaphore-protocol/boilerplate/tree/main/apps/web-app

Related Issue(s)

Closes #836

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have run yarn format and yarn lint without getting any errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@vplasencia
Copy link
Member

Hey @yagopajarino!

If you run yarn in the project root directory, do you see that the yarn.lock file was modified? If so, can you also push these changes?

@yagopajarino
Copy link
Contributor Author

Pushed the new yarn.lock :)

@cedoor
Copy link
Member

cedoor commented Aug 7, 2024

Hi @yagopajarino, could you solve the conflicts?

@yagopajarino
Copy link
Contributor Author

Hi @cedoor! I just synced the fork and solved the conflicts, let me know if there are any additional changes needed

@cedoor
Copy link
Member

cedoor commented Aug 13, 2024

@yagopajarino looks like there're still conflicts.

@yagopajarino
Copy link
Contributor Author

Hi @cedoor! Fixed the conflicts

@yagopajarino
Copy link
Contributor Author

Hi @vplasencia made some changes, let me know what do you think :)

Btw thanks a lot for the reviews

Copy link
Member

@vplasencia vplasencia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! I just left a few comments to improve the UI.

Also, the icons and styles folders inside the cli-template-monorepo-subgraph can be removed since those are used in a chakra project.

I think that after these small updates, the PR is ready to be merged. Thank you very much for the great work! 🙏

@yagopajarino
Copy link
Contributor Author

Thanks for the feedback! I made the changes

Copy link
Member

@vplasencia vplasencia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Thank you for the updates.

We can remove the LogContext.ts and SemaphoreContext.ts from both templates and just keep the new ones with tsx extension.

I just noticed that in the Semaphore Subgraph template, we should use import { SemaphoreSubgraph } from "@semaphore-protocol/data" instead of import { SemaphoreEthers } from "@semaphore-protocol/data". The folder structure won't change.

For more reference:

@yagopajarino
Copy link
Contributor Author

Hi @vplasencia! Made the changes

@vplasencia
Copy link
Member

Hey @yagopajarino thank you. Could you also remove the useSemaphore.ts file inside the hooks folder in both web apps?

@yagopajarino
Copy link
Contributor Author

Done @vplasencia 🚀

Copy link
Member

@vplasencia vplasencia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the great work @yagopajarino! 🙏

@cedoor cedoor merged commit 67060dd into semaphore-protocol:main Oct 21, 2024
5 checks passed
Copy link

gitpoap-bot bot commented Oct 21, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2024 Semaphore Contributor:

GitPOAP: 2024 Semaphore Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update UI code of cli-template-monorepo-ethers and cli-template-monorepo-subgraph
3 participants