-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cli monorepo ethers and subgraph web app UI #841
Conversation
…o-subgraph web app UI re semaphore-protocol#836
Hey @yagopajarino! If you run |
Pushed the new |
Hi @yagopajarino, could you solve the conflicts? |
Hi @cedoor! I just synced the fork and solved the conflicts, let me know if there are any additional changes needed |
@yagopajarino looks like there're still conflicts. |
Hi @cedoor! Fixed the conflicts |
Hi @vplasencia made some changes, let me know what do you think :) Btw thanks a lot for the reviews |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! I just left a few comments to improve the UI.
Also, the icons
and styles
folders inside the cli-template-monorepo-subgraph
can be removed since those are used in a chakra project.
I think that after these small updates, the PR is ready to be merged. Thank you very much for the great work! 🙏
packages/cli-template-monorepo-ethers/apps/web-app/src/components/PageContainer.tsx
Outdated
Show resolved
Hide resolved
Thanks for the feedback! I made the changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! Thank you for the updates.
We can remove the LogContext.ts
and SemaphoreContext.ts
from both templates and just keep the new ones with tsx
extension.
I just noticed that in the Semaphore Subgraph template, we should use import { SemaphoreSubgraph } from "@semaphore-protocol/data"
instead of import { SemaphoreEthers } from "@semaphore-protocol/data"
. The folder structure won't change.
For more reference:
packages/cli-template-monorepo-subgraph/apps/web-app/src/components/PageContainer.tsx
Outdated
Show resolved
Hide resolved
packages/cli-template-monorepo-ethers/apps/web-app/src/components/PageContainer.tsx
Outdated
Show resolved
Hide resolved
Hi @vplasencia! Made the changes |
Hey @yagopajarino thank you. Could you also remove the |
Done @vplasencia 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for the great work @yagopajarino! 🙏
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2024 Semaphore Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Description
Update cli template ethers and subgraph web app UI using boilerplate code from https://github.com/semaphore-protocol/boilerplate/tree/main/apps/web-app
Related Issue(s)
Closes #836
Checklist
yarn format
andyarn lint
without getting any errors