Fix firmware.py opening files and not closing #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #491 +/- ##
===========================================
+ Coverage 94.85% 94.89% +0.03%
===========================================
Files 74 74
Lines 7948 7951 +3
===========================================
+ Hits 7539 7545 +6
+ Misses 409 406 -3 ☔ View full report in Codecov by Sentry. |
jdlcdl
reviewed
Dec 9, 2024
src/krux/firmware.py
Outdated
| new_size, | ||
| 65536, | ||
| True, | ||
| firmware_with_header_hash, | ||
| ) | ||
| firmware_file.close() |
There was a problem hiding this comment.
Might this need to be within the "finally" branch of try/except, in case of a write failure? or the write_data() call within the context of "with open()" so that it's automagically closed?
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Files were being opened without being close, this could lead to errors in another open operation on the same file that was left open
What is the purpose of this pull request?