Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix btn yahboom not working #484

Closed

Conversation

tadeubas
Copy link
Contributor

What is this PR for?

Fix Yahboom v1.1 btn not working after this change: 093285a#diff-ce5d263efd2e8bec3590c6bd71cdcb3838a0eac2b949ed6abfa3e4f2210ddb17L252

Also:

  • removed unnecessary code at boot.py
  • fixed error msg appearing on simulator Camera not found: 'NoneType' object has no attribute 'release'

What is the purpose of this pull request?

  • Bug fix
  • New feature
  • Docs update
  • Other

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.89%. Comparing base (c201ff8) to head (9a25109).

Files with missing lines Patch % Lines
src/krux/input.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #484      +/-   ##
===========================================
- Coverage    94.91%   94.89%   -0.02%     
===========================================
  Files           74       74              
  Lines         7940     7941       +1     
===========================================
  Hits          7536     7536              
- Misses         404      405       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tadeubas
Copy link
Contributor Author

tadeubas commented Dec 8, 2024

Sorry, don' t know what happened but it is working fine with the current code. Will close this PR

@tadeubas tadeubas closed this Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant