Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 24.11.1 #478

Merged
merged 4 commits into from
Nov 19, 2024
Merged

Release 24.11.1 #478

merged 4 commits into from
Nov 19, 2024

Conversation

odudex
Copy link
Member

@odudex odudex commented Nov 19, 2024

What is this PR for?

This release addresses a vulnerability affecting AES-CBC encrypted mnemonics stored on flash storage, SD cards, and QR codes. Due to an implementation error, the Initialization Vector (IV) in our CBC encryption, which uses camera-generated entropy, was not being correctly utilized, which meant it did not provide the intended additional entropy.

What is the purpose of this pull request?

  • Bug fix
  • New feature
  • Docs update
  • Other

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.91%. Comparing base (9cd6e97) to head (9e4f7e2).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #478   +/-   ##
=======================================
  Coverage   94.91%   94.91%           
=======================================
  Files          74       74           
  Lines        7951     7952    +1     
=======================================
+ Hits         7547     7548    +1     
  Misses        404      404           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@odudex odudex requested a review from jdlcdl November 19, 2024 18:14
@odudex odudex merged commit 2006140 into main Nov 19, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants