Tamper Detection #471
Merged
Tamper Detection #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add introduction to anti-tamper doc
allow PIN with letters and special chars allow disabling PIN flash snapshot has words dedicated to SPIFFS
adapt fill_flash to all devices update flash hash docs
move keypad index indicator down
don't mistake compactSeedQR with string QRs
set exec_allowed from spiffs to false
slightly expand prompt touch regions
Docs: Fix icon scale of backup templates II
Add BIP85 passwords
jdlcdl
reviewed
Oct 31, 2024
There was a problem hiding this comment.
as of 108th commit 4c91316
- have followed this branch since the beginning,
- up to date on visual code review
still need to test beta10 on Amigo- no major issues found on Amigo, I focused testing on:
- *.mpy files on sdcard are not imported
- derived passwords and mnemonics from bip85 are as expected
- flash-map and tamper-check-flash-hash features, functionality, reproducibility
as discussed, assuming this to be merged to develop and then readied w/ final adjustments towards release, we discussed todo:
- feed the watchdog when looping in capture_image_with_sufficient_entropy(),
- flush input events while flash_map is being drawn so that user sees it when done,
- update docs about users filling-flash and timing out after 25s with "Insufficient entropy" in a dark room.
note: I see that the 3 commits below resolve discussed todos.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Add a tamper detection mechanism called "Tamper Code Flash Hash" or "TC Flash Hash".
The mechanism combines cryptographic hashes, a Tamper Check Code, and camera-generated entropy to create a tamper indicator that is unique to each device, represented by a memorable image and four words.
A side feature is the "Flash Map", which is a visual tool to check the areas of the flash memory that contain data.
This PR also covers the addition of BIP85 base64 passwords.
What is the purpose of this pull request?