Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid exiting when user misclick and cancel the load of a file #469

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

tadeubas
Copy link
Contributor

What is this PR for?

  • Fixed bug when signing message with empty file
  • Avoid exiting when user misclick and cancel the load of a file

What is the purpose of this pull request?

  • Bug fix
  • New feature
  • Docs update
  • Other

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.75%. Comparing base (fdee14e) to head (03678f9).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
src/krux/pages/file_manager.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #469      +/-   ##
===========================================
+ Coverage    94.70%   94.75%   +0.04%     
===========================================
  Files           70       70              
  Lines         7573     7581       +8     
===========================================
+ Hits          7172     7183      +11     
+ Misses         401      398       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odudex
Copy link
Member

odudex commented Oct 15, 2024

Thank you!
It would be nice to add a test to cover new code and meet the patch requirements.

@odudex
Copy link
Member

odudex commented Oct 15, 2024

Thank you!

@odudex odudex merged commit 6420c61 into selfcustody:develop Oct 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants