Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update docs for installing-from-gui section #450

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

qlrd
Copy link
Contributor

@qlrd qlrd commented Aug 29, 2024

Description

This PR just update the "Installing from GUI" section:

  • Split text in to many sections
  • update to newest installer release (v0.0.2-alpha)

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.21%. Comparing base (1b03495) to head (569bd12).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #450   +/-   ##
========================================
  Coverage    94.21%   94.21%           
========================================
  Files           59       59           
  Lines         7259     7259           
========================================
  Hits          6839     6839           
  Misses         420      420           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odudex
Copy link
Member

odudex commented Sep 2, 2024

Exemplary documentation! There are minor issues. 2 broken links, listed in mkdocs debug INFO (one left by me!)
On /snippets/verify-the-signature-trust-tip.en.txt should #verify-its-authenticity become #verify-the-authenticity?
Could you please fix mine to?
On /getting-started/usage/navigating-the-main-menu.en.md . [More about wallet attributes](./loading-a-mnemonic.md/#attributes) becomes [More about wallet attributes](./loading-a-mnemonic.md/#confirm-wallet-attributes)

…city'

fixed link of 'More about wallet attributes'
@qlrd
Copy link
Contributor Author

qlrd commented Sep 3, 2024

On /snippets/verify-the-signature-trust-tip.en.txt should #verify-its-authenticity become #verify-the-authenticity? Could you please fix mine to? On /getting-started/usage/navigating-the-main-menu.en.md . [More about wallet attributes](./loading-a-mnemonic.md/#attributes) becomes [More about wallet attributes](./loading-a-mnemonic.md/#confirm-wallet-attributes)

Fixed both (i think)

@odudex
Copy link
Member

odudex commented Sep 3, 2024

Thank you!

@odudex odudex merged commit 8166a9e into selfcustody:develop Sep 3, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants