Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embit remove unused py_ripemd160.py #442

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

tadeubas
Copy link
Contributor

@tadeubas tadeubas commented Aug 12, 2024

removing from Docker as it is used only in Python, micropython uses ripemd160 from hashlib. Also ripemd160 is only used in embit for miniscript. ripemd160 is used everywhere as hash160.

Description

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.15%. Comparing base (981b215) to head (1c68666).
Report is 50 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #442   +/-   ##
========================================
  Coverage    94.15%   94.15%           
========================================
  Files           58       58           
  Lines         7189     7189           
========================================
  Hits          6769     6769           
  Misses         420      420           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odudex odudex merged commit c5e0356 into selfcustody:develop Aug 20, 2024
7 checks passed
@odudex
Copy link
Member

odudex commented Aug 20, 2024

Thank you!

@tadeubas tadeubas deleted the embit-clean branch September 4, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants