-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some issues with qrcode progress #441
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #441 +/- ##
===========================================
- Coverage 94.31% 94.19% -0.13%
===========================================
Files 58 58
Lines 7146 7153 +7
===========================================
- Hits 6740 6738 -2
- Misses 406 415 +9 ☔ View full report in Codecov by Sentry. |
I am doing some final adjustments, I will place it as draft for now Follow attached some QR code examples with edge cases for 240px width devices (e.g. yahboom): bbqr22.mp4pmofn.mp4 |
Great improvements! |
Thanks for the review!
Yes, this is fixed now with 136b228
I've noticed a change in the Yahboom tap behavior, before I would tap 5 times or more to get the entropy capture, now I tested it and the worst case was 3 taps, maybe it's just my impression...
Sorry, I didn't test it on Amigo, so I didn't know about the text in the back. clear() returned with 3f9e6be |
Great improvements! Thank you! |
Description
self.portrait = True
but it only changed to portrait mode after the call toinitialize_lcd()
What is the purpose of this pull request?