Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture QR Code - Show Frame Status and Refactor #428

Merged
merged 20 commits into from
Aug 9, 2024

Conversation

odudex
Copy link
Member

@odudex odudex commented Jul 24, 2024

Description

While UR QR codes employ a complex approach where a progress bar is suitable, BBQr and PMofN require the capture of all their frames. To improve understanding of the capture progress, I'm experimenting with an alternative to the simple, continuous progress bar, where it is possible to visualize captured and missing frames, as well as the last captured one, which helps to determine what frame the wallet is currently showing.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

refactor capture_qr_loop as a Page
@odudex odudex changed the title Capture qr refactor Capture QR Code - Show Frame Status and Refactor Jul 24, 2024
@odudex odudex marked this pull request as draft July 24, 2024 16:38
@odudex odudex changed the base branch from main to develop July 24, 2024 17:54
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 94.30894% with 7 lines in your changes missing coverage. Please review.

Project coverage is 94.31%. Comparing base (d2ab267) to head (200dffb).

Files Patch % Lines
src/krux/camera.py 16.66% 5 Missing ⚠️
src/krux/pages/qr_capture.py 97.80% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #428      +/-   ##
===========================================
- Coverage    94.72%   94.31%   -0.41%     
===========================================
  Files           57       58       +1     
  Lines         7127     7146      +19     
===========================================
- Hits          6751     6740      -11     
- Misses         376      406      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odudex odudex marked this pull request as ready for review August 2, 2024 12:24
@odudex odudex merged commit 068c466 into selfcustody:develop Aug 9, 2024
7 checks passed
@odudex odudex deleted the capture_qr_refactor branch September 26, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant