Adds "< " to "Back" menu items

[jdlcdl]

Description

Perhaps with another "arrow" glyph, this will look nicer, but "< Back" is still very identifiable as a special menu item.

Also changed some tuples' 2nd item to the more standard "lambda: MENU_EXIT" instead of "lambda: None"

What is the purpose of this pull request?

• Bug fix
• New Feature
• Documentation update
• Other

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (develop@9eb1bcb). Learn more about missing BASE report.
Report is 14 commits behind head on develop.

Additional details and impacted files

@@            Coverage Diff             @@
##             develop     #420   +/-   ##
==========================================
  Coverage           ?   94.63%           
==========================================
  Files              ?       57           
  Lines              ?     7078           
  Branches           ?        0           
==========================================
  Hits               ?     6698           
  Misses             ?      380           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[odudex]

The lambda: MENU_EXIT didn't change behaviors, right?

[tadeubas]

Hi @jdlcdl ! Can we create a constant for Back and reuse it everywhere?

[jdlcdl]

2nd item should return None to express that it's ignored.

[jdlcdl]

all 2nd items should return None to express that they're ignored, or they could return num words (or None) if they're not ignored.

[jdlcdl]

2nd item should be None to express that it's ignored.

[jdlcdl]

2nd item should be None to express that it's ignored.

[jdlcdl]

The lambda: MENU_EXIT didn't change behaviors, right?

I was trying to standardize exiting menus with this MENU_EXIT status, but often it is ignored and doesn't matter. I wasn't intending to alter behavior. I'll move these back to the way they were because I'm not sure if they're inspected elsewhere.

[odudex]

The lambda: MENU_EXIT didn't change behaviors, right?

I was trying to standardize exiting menus with this MENU_EXIT status, but often it is ignored and doesn't matter. I wasn't intending to alter behavior. I'll move these back to the way they were because I'm not sure if they're inspected elsewhere.

I was just asking because I didn't know too, but if you tested it's ok!

[jdlcdl]

Hi @jdlcdl ! Can we create a constant for Back and reuse it everywhere?

Still not ready, but working in that direction.

latest commit tries to implement a cta_back() reusable in pages/init.py but to pass tests, couldn't use it in one place, and to pass i18n checks, had to feed it i18n food at least once. Still a work in progress, and have not tested it on device (only limited testing in simulator so far). It's leading me to believe that "Menu" class might take an optional cta_back param and set this up by default so that every menu doesn't always need it; then it would be easier to move from Menu item to Page later.

[jdlcdl]

Altering to ready-for-review.

• i18n food kluge was fixed above, ty to tadeubas.

• assert_has_calls() was failing because cta_back() was returning a callable that returned MENU_EXIT, optionally could pass in a different status and it would return a callable that returns it) but this is not always the case, in the settings menu, we need to pass a callable to cta_back() which will be returned (instead of a callable that returns that callable).

[odudex]

Reviewed, tested and merged. Thank you!