Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assorted non-firmware changes for release-24.07.0 #418

Merged
merged 2 commits into from
Jul 14, 2024

Conversation

jdlcdl
Copy link
Collaborator

@jdlcdl jdlcdl commented Jul 14, 2024

Description

  • Uses poetry run poe simulator instead of poetry run python simulator.py for screenshots.
  • README.md mentions removal of compiler at top of "Live debug a device" section, instead of at bottom.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Copy link

codecov bot commented Jul 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.66%. Comparing base (99d882f) to head (10607c1).

Additional details and impacted files
@@               Coverage Diff                @@
##           release-24.07.0     #418   +/-   ##
================================================
  Coverage            94.66%   94.66%           
================================================
  Files                   57       57           
  Lines                 7073     7073           
================================================
  Hits                  6696     6696           
  Misses                 377      377           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdlcdl jdlcdl changed the title ... python simulator.py becomes ... poe simulator for screenshots Assorted non-firmware changes for release-24.07.0 Jul 14, 2024
@odudex
Copy link
Member

odudex commented Jul 14, 2024

Thank you!

@odudex odudex merged commit 7285f1b into selfcustody:release-24.07.0 Jul 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants