Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small changes to release-24.07.0 #417

Merged

Conversation

tadeubas
Copy link
Contributor

@tadeubas tadeubas commented Jul 12, 2024

  • Change high fees warning from 30 to 10%
  • Added test to P2TR PSBT without fingerprint
  • Changelog small text changes and additions:
    • Sorted SD file explorer
    • Address explorer starts at index 0
    • Small fixes and optimizations

Description

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.66%. Comparing base (312860b) to head (4417bce).

Additional details and impacted files
@@                 Coverage Diff                 @@
##           release-24.07.0     #417      +/-   ##
===================================================
+ Coverage            94.64%   94.66%   +0.02%     
===================================================
  Files                   57       57              
  Lines                 7073     7073              
===================================================
+ Hits                  6694     6696       +2     
+ Misses                 379      377       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odudex
Copy link
Member

odudex commented Jul 13, 2024

Thank you!
Nice you made the Taproot null fingerprint test to also cover SD card workflow!

@odudex odudex merged commit ae8fa47 into selfcustody:release-24.07.0 Jul 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants