Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added wdt.feed() on tools > wipe divice #327

Merged
merged 7 commits into from
Feb 29, 2024

Conversation

tadeubas
Copy link
Contributor

@tadeubas tadeubas commented Feb 27, 2024

  • added wdt.feed() on tools > wipe divice
  • tools > wipe divice extra msg: "Do not power off, it may take a while to complete."
  • Translations

Docs:

  • Removing ex: as this is best to avoid in english
  • docs more info about printers

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.30%. Comparing base (54ffae4) to head (230b851).

Additional details and impacted files
@@                 Coverage Diff                 @@
##           integrated_changes     #327   +/-   ##
===================================================
  Coverage               93.30%   93.30%           
===================================================
  Files                      52       52           
  Lines                    6019     6020    +1     
===================================================
+ Hits                     5616     5617    +1     
  Misses                    403      403           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdlcdl
Copy link
Collaborator

jdlcdl commented Feb 28, 2024

Yikes, this never even crossed my mind, but it should have. I suspect it was rebooting leaving user with false sense that it worked. Very nice catch!

@tadeubas
Copy link
Contributor Author

Hello @jdlcdl! Amazing job you and @odudex did on the wipe device feature! On my dock the internal flash memory is about 2.7 MB and erasing a full memory would take about 38s (currently wdt timeout is 30s), so yes, it could be the case (in rare circumstances) that it was rebooting before finishing the work!

@odudex odudex merged commit 47b4d52 into selfcustody:integrated_changes Feb 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants