Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build error when files with Windows line ending CRLF (\r\n) #317

Merged
merged 1 commit into from
Feb 17, 2024

Conversation

tadeubas
Copy link
Contributor

Description

When git is installed on Windows it uses as default CRFL (\r\n) line endings, and this break the build process. This commit fixes that

More info: https://docs.github.com/en/get-started/getting-started-with-git/configuring-git-to-handle-line-endings

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2fb80fe) 89.21% compared to head (9eb3aad) 89.21%.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           integrated_changes     #317   +/-   ##
===================================================
  Coverage               89.21%   89.21%           
===================================================
  Files                      52       52           
  Lines                    6010     6010           
===================================================
  Hits                     5362     5362           
  Misses                    648      648           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odudex odudex merged commit 0bd6d2d into selfcustody:integrated_changes Feb 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants