Integrated changes #314
Merged
Integrated changes #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor login and settings_page tests
Encryption load error now shows only one error message
won't try to encode huge QRs and blow RAM
… integrated_changes
* krux.pages.settings_page accesses singleton "store" instead of class "Store" * krux.pages.settings_page explicitely calls store.save_settings() when exiting * krux.settings.Store adds attribute ".dirty" boolean to track settings changes * krux.settings.Store adds method ".update_file_location()" to delete old file * krux.settings.Store.save_settings() method writes only if ".dirty" and file would be altered * adds new tests and adjusts existing tests.
* krux.settings.Setting.set still calls store.set() but only for custom settings, it will call store.delete() for defaults -- to clean-up the store
* krux.settings.Store.get no longer builds-out the settings dictionary, works with a deepcopy instead
* krux.settings.Store.delete is used to remove default values and empty parent namespaces
* an all-defaults settings.json file will contain an empty dict "{}"
* adds new tests and adjusts existing tests.
qr_code_frame_calc branch: code review + tests
…efaults Reduced settings writes without defaults
add script to create glyphs from pbm files
… integrated-bugfix
… integrated_changes
docs changes
Improve the scritps that generate fonts
update font glyphs
Tiny seed 24 words page 0 now waits for button release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to check action tests coverage and prepare updates from last months for a new release.