Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added poethepoet as task runner #306

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

qlrd
Copy link
Contributor

@qlrd qlrd commented Jan 10, 2024

Description

  • add poethepoet package to pyproject.toml;
  • added tasks;
  • add little changes on README to pointing those `tasks;

Poe the poet

Poethepoet is a nice task runner that works well with poetry.

Created tasks

  • poetry run poe format (execute poetry run black ./src and poetry run black ./tests);
  • poetry run poe lint (execute poetry run pylint ./src can be expanded for more folders);
  • poetry run poe test (execute pytest --cache-clear --cov src/krux --cov-report html --show-capture all --capture tee-sys -r A ./tests);
  • poetry run poe pre-commit (execute all tasks above);

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other: tools for speedup some development tasks

qlrd added 2 commits January 10, 2024 15:01
Added some poe tasks for formatting, linting and tests

Added some changes on README to point the format, linting and tests with poe
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 499 lines in your changes are missing coverage. Please review.

Comparison is base (a304206) 92.24% compared to head (6f8e1ba) 86.55%.
Report is 214 commits behind head on integrated_changes.

Files Patch % Lines
src/krux/pages/capture_entropy.py 12.37% 85 Missing ⚠️
src/krux/pages/qr_view.py 40.00% 75 Missing ⚠️
src/krux/pages/settings_page.py 18.36% 40 Missing ⚠️
src/krux/pages/sign_message_ui.py 67.61% 34 Missing ⚠️
src/krux/pages/new_mnemonic/dice_rolls.py 79.02% 30 Missing ⚠️
src/krux/buttons.py 63.75% 29 Missing ⚠️
src/krux/printers/thermal.py 6.66% 28 Missing ⚠️
src/krux/pages/home.py 67.18% 21 Missing ⚠️
src/krux/pages/login.py 57.14% 21 Missing ⚠️
src/krux/touch.py 65.45% 19 Missing ⚠️
... and 24 more
Additional details and impacted files
@@                  Coverage Diff                   @@
##           integrated_changes     #306      +/-   ##
======================================================
- Coverage               92.24%   86.55%   -5.70%     
======================================================
  Files                      42       51       +9     
  Lines                    5290     6084     +794     
======================================================
+ Hits                     4880     5266     +386     
- Misses                    410      818     +408     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odudex odudex merged commit 8866ccc into selfcustody:integrated_changes Jan 12, 2024
3 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants