Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

an alternative to krux_colors.py #302

Merged
merged 2 commits into from
Dec 27, 2023

Conversation

jdlcdl
Copy link
Collaborator

@jdlcdl jdlcdl commented Dec 25, 2023

Description

An alternative utility script to krux_colors.py, for review by others...
potentially to replace krux_colors.py because it converts both ways, and because I believe there is a green error in krux_colors.py (however if I'm correct and krux_colors.py is adjusted to solve green, rgbconv.py would still require an option to swap byte-order).

I have a gist with further thoughts: here

What is the purpose of this pull request?

  • [* ] Bug fix
  • [* ] New Feature
  • Documentation update
  • Other

@odudex
Copy link
Member

odudex commented Dec 25, 2023

Good catch! I wonder your previous work reviewing Shannon's entropy, sweeping color spectrum in search of higher entropy lead you to this finding.
I believe we will have to review theme colors. Probably some funny things I noticed on colors aren't caused by display quality as I previously though, but this green bits order issue.
Your neat quality enhancing contributions are very inspiring. Thanks!

@jdlcdl
Copy link
Collaborator Author

jdlcdl commented Dec 25, 2023

I wonder your previous work reviewing Shannon's entropy, sweeping color spectrum

Yes, that's exactly what caught me onto this. For days, it's been bugging me, making me feel guilty that I never understood what was happening... and that I had bailed before figuring it out.

@odudex
Copy link
Member

odudex commented Dec 27, 2023

Great PR, now it's time to review theme colors, especially grays. Will also change simulator and Android code using rgb16_to_rgb24 as reference. Thanks!

@odudex odudex merged commit 48a33a6 into selfcustody:integrated_changes Dec 27, 2023
0 of 5 checks passed
@jdlcdl jdlcdl deleted the krux_colors branch July 21, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants