Less frequent writes of settings.json to sd/flash #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* krux.pages.settings_page accesses singleton "store" instead of class "Store" * krux.pages.settings_page explicitely calls store.save_settings() when exiting * krux.settings.Store adds attribute ".dirty" boolean to track settings changes * krux.settings.Store adds method ".update_file_location()" to delete old file * krux.settings.Store.save_settings() method writes only if ".dirty" and file would be altered * adds new tests and adjusts existing tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somewhat minor change to reduce how many writes of "settings.json" are made to flash/sd.
Defaults will be included because they are built-out as they are accessed. As the user navigates deeper into settings-namespaces, more defaults will be built out, so settings will be written more often than necessary.