Krux script checks + simulator fix + small bugfix #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tadeubas
commented
Nov 22, 2023
tadeubas
commented
- Adding checks for params and error messages on krux script
|
As of 7a956cc, I'm choosing to use this draft-pr of the 'krux' script for 'build'. Will alert here if problems. |
… integrated_changes
tadeubas
changed the title
|
@odudex I've added a commit to fix simulator with missing mocks and a small fix to the first words suggested to import mnemonic from words (none word start with X, so it is disabled for the first char of the words). Can you plz accept this PR? |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.