Bugfixes #288
Bugfixes #288
Conversation
Merge released main into develop
Docs review
Update docs from main
docs update
update docs
Formatting
adjust changelog
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #288 +/- ##
==========================================
+ Coverage 92.14% 92.24% +0.10%
==========================================
Files 42 42
Lines 5273 5290 +17
==========================================
+ Hits 4859 4880 +21
+ Misses 414 410 -4 ☔ View full report in Codecov by Sentry. |
i18n/translations/fr-FR.json
Outdated
| @@ -225,6 +225,7 @@ | |||
| "Use camera's entropy to create a new mnemonic": "Utilisez l'entropie de la caméra pour créer un nouveau mnémonique", | |||
| "Used: ": "Utilisé: ", | |||
| "Value %s out of range: [%s, %s]": "Valeur% s hors de portée: [% s,% s]", | |||
| "Value must be multiple of %s": "La valeur doit être multiple de% s", | |||
There was a problem hiding this comment.
"La valeur doit être un multiple de %s"
No big deal on the missing "un", but the space is on the wrong side of the % above and won't replace, i think.
There was a problem hiding this comment.
oh I missed the "un". If I get another erro I'll put this together, otherwise let's leave it for next release
There was a problem hiding this comment.
Added this fix to integrated_changes after I merged changes from main
add test to encryption pbkdf2 settings
| import pytest | ||
| from Crypto.Cipher import AES |
There was a problem hiding this comment.
plz remove this unused libs
| ), | ||
| ] | ||
| for case in cases: | ||
| ctx = create_ctx(mocker, case[0]) |
There was a problem hiding this comment.
Context and Login objects are not necessary, you could call the Settings functions as other examples on this file. So all the navigation procedures would also be removed from the test
Bugfixes
Encrypted Mnemonic QR codes would fail to decrypt if PBKDF2 iterations settings was changed to non multiple of 10,000.
QR code transcription helpers that highlight regions could crash on edges of some QR code sizes.
Address navigation "previous" menu option wouldn't show correct number.