Screensaver

[tadeubas]

Added screensaver on menu screens and other small changes!

[codecov]

Codecov Report

Merging #255 (fa533dd) into develop_irq_based (72a1afb) will decrease coverage by 1.33%.
Report is 32 commits behind head on develop_irq_based.
The diff coverage is 70.89%.

@@                  Coverage Diff                  @@
##           develop_irq_based     #255      +/-   ##
=====================================================
- Coverage              92.14%   90.82%   -1.33%     
=====================================================
  Files                     42       43       +1     
  Lines                   5273     5470     +197     
=====================================================
+ Hits                    4859     4968     +109     
- Misses                   414      502      +88     

Files	Coverage Δ
src/krux/firmware.py	100.00% <100.00%> (ø)
src/krux/metadata.py	100.00% <100.00%> (ø)
src/krux/pages/tools.py	66.03% <100.00%> (ø)
src/krux/rotary.py	98.57% <100.00%> (-0.10%)	⬇️
src/krux/translations.py	100.00% <ø> (ø)
src/krux/krux_settings.py	94.40% <88.88%> (-0.50%)	⬇️
src/krux/pages/home.py	88.27% <80.00%> (ø)
src/krux/pages/print_page.py	92.30% <50.00%> (ø)
src/krux/pages/settings_page.py	76.47% <0.00%> (-0.16%)	⬇️
src/krux/touch.py	96.32% <96.66%> (-1.28%)	⬇️
... and 12 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[ghost]

As Krux matures, we should really try to avoid doing "drive-by" feature additions like this without either filing an issue or opening a discussion first to first see if we want to add it, and second hash out the details of how it should look and work.

[tadeubas]

This is just a already working PR, we can discuss it more here, create an issue or open a discussion pointing to this PR... and if we find this irrelevant, just close the PR pointing the arguments / issue / discussion

[jdlcdl]

This branch worked for me, as far as I can tell.

I used ktool's "-s" argument to boot the firmware without touching SPI Flash. In settings, screensaver was set to 5m so I switched it to 1.
When the screensaver came on, it did what I expected, and I left it running wondering if the board would heat up noticeably to the touch, but it didn't (this is a good thing).

However, after a few rounds of the screensaver starting and being woken up by touch, I noticed that my touches were not registering. When I went to settings/touchscreen, I was on 22 as expected for my amigo. I reset the board and asked ktool to boot the firmware again with -s option, and I have not yet been able to reproduce the problem where waking from screensaver effectively "bugs" my touchscreen. I don't know what happened there.

One error that I did catch, never seen before but it is reproducible, is entering touchscreen and then hitting "Esc" without changes shows me

Error: AttributeError("'Touch' object has no attribute 'touch_driver'",)
``` in red.   But I notice no other problems after touching past this error screen.

[odudex]

Error: AttributeError("'Touch' object has no attribute 'touch_driver'",)
``` in red.   But I notice no other problems after touching past this error screen.

I did some recent adjustments on touch, some bugs may be expected, I think this branch don't have the latest

[ghost]

This is just a already working PR, we can discuss it more here, create an issue or open a discussion pointing to this PR... and if we find this irrelevant, just close the PR pointing the arguments / issue / discussion

@tadeubas Can you update your PR to explain why Krux needs a screensaver with thoughts on how it should function? Is this privacy/security related or aesthetics? I'd like to know the motivation for it. Does the battery life suffer because of this?

For future reference, this is how I'd like to see development progress: https://github.com/selfcustody/krux#contributing

Without a paper trail or social protocol to decisions like this, the project is in chaos. That's fine when you're a solo developer, but not when you're working as a group.

[tadeubas]

The project is not in chaos, I am always verbalizing myself on the Telegram group and here on Github, also I always check things with odudex personally, I just don't want bureaucracy and other things that makes me less likely to contribute, because I really like the project! Anyway, I think this is a "develop" branch and nothing added here NEEDS to be in the release, so I don't think this screensaver is of a big issue to worth discussing, it is just a screensaver... do you use Krux? I have a dock device, sometimes I left it on testing and working with things, the screen is very bright and I wonder if pixels could fade with time, also I live in Brazil and I don't have too much money to be spending on new devices.

[odudex]

Merged here