Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Chinese JSON file #77

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Update Chinese JSON file #77

merged 2 commits into from
Aug 27, 2024

Conversation

theBillLee
Copy link
Contributor

Description

This PR provides the translation for Krux-installer from English to Chinese. It ensures that the UI and instructional text are fully localized for Chinese-speaking users, enhancing usability and accessibility.

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Copy link
Collaborator

@qlrd qlrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @theBillLee,

Wonderful work!

Like i talked to you before, in order for you (or anyone) to create a translation that is more suitable for the specifics of the Chinese language, I will have to change the method used on i18n json files (like something similar to krux itself, using %s replace characters).

As this will be a process, I will certainly let you know about the update

@qlrd qlrd self-requested a review August 27, 2024 15:55
@qlrd
Copy link
Collaborator

qlrd commented Aug 27, 2024

@theBillLee, I approved and then disaproved your PR since an error occured on lint process, so i will ask (when you can) to fix it (sorry about that, I did not observe adequately in this aspect).

It's a little one: in the lines 104 and 105 there is a duplicate of "Flash with" key. Just remove one of them and this error will be fixed.

"unzip_stable_screen": {
    "Flash with": "通过刷入",
--->"Flash with": "通过刷入",
    "Air-gapped update with": "通过气隙隔离更新",
    "Unziping": "解压缩",
    "Unziped": "已解压"
  }

before commit your change, i suggest to run the following commands:

poetry run poe lint
poetry run poe test

if all runs ok, then commit and push your change

@qlrd qlrd merged commit 6fe6131 into selfcustody:main Aug 27, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants