Major updates of libraries to go to a stable version of the software #36
Conversation
refacftored test renamed tests to .mts extension updated README.md
… create configuration files
removed unecessary src/assets files
Added Disclaimer on CHANGELOG Updated README
|
|
||
| describe('Check created configuration', () => { | ||
|
|
||
| it('should \'appVersion\' property be equal to the defined in package.json', async () => { |
There was a problem hiding this comment.
Assuming that these are human-readable error messages that a user might see, I've left some 'wording' suggestions below. If it is the case that these are only written to logs... I would NOT make these changes... because maybe there is an automated tool looking for "should " at the front of the log info.
'appVersion' property should be equal to the value define in package.json
There was a problem hiding this comment.
@jdlcdl, thanks for the review.
because maybe there is an automated tool looking for "should " at the front of the log info.
There isn't an automated tool. The string after it is an argument that prints a message. I only put should at the beginning of the sentence, a personal protocol based on BDD, completely forgetting about grammar 😞.
I will make these changes
| expect(appVersion).to.equal(version) | ||
| }) | ||
|
|
||
| it('should \'resources\' property be properly set for the platform', async () => { |
There was a problem hiding this comment.
'resources' property should be properly set for the platform
| } | ||
| }) | ||
|
|
||
| it('should \'os\' property be properly set for the platform', async () => { |
There was a problem hiding this comment.
'os' property should be properly set for the platform
| expect(os).to.equal(process.platform) | ||
| }) | ||
|
|
||
| it('should \'versions\' property to be an Array with 0 elements', async () => { |
There was a problem hiding this comment.
'versions' property should be an Array with 0 elements
| expect(versions.length).to.equal(0) | ||
| }) | ||
|
|
||
| it('should \'version\' property to be equal \'Select version\'', async () => { |
There was a problem hiding this comment.
'version' property should be equal to 'Select version'
| expect(version).to.equal('Select version') | ||
| }) | ||
|
|
||
| it('should \'device\' property to be equal \'Select device\'', async () => { |
There was a problem hiding this comment.
'device' property should be equal to 'Select device'
| expect(device).to.equal('Select device') | ||
| }) | ||
|
|
||
| it('should \'showFlash\' property to be equal \'false\'', async () => { |
There was a problem hiding this comment.
'showFlash' property should be equal to 'false'
Added minor updates to CHANGELOG; Added WARNING.md; Fixed some grammars on tests.
|
I note that all of my previous suggestions have been addressed. I did read through WARNING.md and issued a pull request with small changes to the qlrd repo. I did not succeed in building, because I have not taken the steps necessary to get my node.js environment in shape, but I see that you have pre-build AppImage and debian installer. They both worked well for me, nothing to report except 'well done!' Thank you qlrd! |
proof-reading suggestions
Description
This PR was made to fix major updates of libraries to go to a stable version of the software.
It don't add any new functionality
0.0.1
Updated main dependencies:
electron: 28.0.0;vite-plugin-electron: 0.15.5;wdio-electron-service: 6.0.2.Refactored
test/e2e/specs:wdio-electron-servicemajor updates that break E2E tests;mtsto suitvite-plugin-electron;23.09.1.Updated
opensslfor windows to3.2.0.Removed MacOS release since the current approach did not worked well
on MacOS;
WARNING:
Artifacts to test
Generated artifacts can be found here
What is the purpose of this pull request?