Skip to content

Commit

Permalink
Merge pull request #2604 from seleniumbase/fix-browser-detection-on-w…
Browse files Browse the repository at this point in the history
…indows

Fix browser-version-detection on Windows
  • Loading branch information
mdmintz authored Mar 15, 2024
2 parents 668d646 + d0263cf commit c0935f5
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ rich==13.7.1

coverage==6.2;python_version<"3.7"
coverage==7.2.7;python_version>="3.7" and python_version<"3.8"
coverage==7.4.3;python_version>="3.8"
coverage==7.4.4;python_version>="3.8"
pytest-cov==4.0.0;python_version<"3.7"
pytest-cov==4.1.0;python_version>="3.7"
flake8==5.0.4;python_version<"3.9"
Expand Down
2 changes: 1 addition & 1 deletion seleniumbase/__version__.py
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
# seleniumbase package
__version__ = "4.24.6"
__version__ = "4.24.7"
8 changes: 4 additions & 4 deletions seleniumbase/core/detect_b_ver.py
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ def linux_browser_apps_to_cmd(*apps):


def chrome_on_linux_path(prefer_chromium=False):
if os_name() != "linux":
if os_name() != OSType.LINUX:
return ""
if prefer_chromium:
paths = ["/bin/chromium", "/bin/chromium-browser"]
Expand Down Expand Up @@ -127,7 +127,7 @@ def chrome_on_linux_path(prefer_chromium=False):


def edge_on_linux_path():
if os_name() != "linux":
if os_name() != OSType.LINUX:
return ""
paths = os.environ["PATH"].split(os.pathsep)
binaries = []
Expand All @@ -144,7 +144,7 @@ def edge_on_linux_path():


def chrome_on_windows_path():
if os_name() != "win32":
if os_name() != OSType.WIN:
return ""
candidates = []
for item in map(
Expand Down Expand Up @@ -172,7 +172,7 @@ def chrome_on_windows_path():


def edge_on_windows_path():
if os_name() != "win32":
if os_name() != OSType.WIN:
return ""
candidates = []
for item in map(
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@
# Usage: coverage run -m pytest; coverage html; coverage report
"coverage": [
'coverage==7.2.7;python_version<"3.8"',
'coverage==7.4.3;python_version>="3.8"',
'coverage==7.4.4;python_version>="3.8"',
'pytest-cov==4.1.0',
],
# pip install -e .[flake8]
Expand Down

0 comments on commit c0935f5

Please sign in to comment.