Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change configuration of provider #313

Merged
merged 12 commits into from
Dec 2, 2024
Merged

Change configuration of provider #313

merged 12 commits into from
Dec 2, 2024

Conversation

sel-bukharov
Copy link
Contributor

@sel-bukharov sel-bukharov commented Nov 19, 2024

What's changed

In this PR we change way to configure provider:

  • auth_url and auth_region are now required to configure provider
  • SEL_REGION and SEL_PROJECT_ID env variables are renamed to INFRA_REGION and INFRA_PROJECT_ID respectively

In addition, resources which was deprecated long time ago was permanently removed from provider:

  • selectel_vpc_role_v2
  • selectel_vpc_token_v2
  • selectel_vpc_user_v2
  • selectel_vpc_vrrp_subnet_v2
  • selectel_vpc_crossregion_subnet_v2

Last but not least: changes such as updating deps and bumping Go version with updating necessary documentation (changelog, readme).

How to review changes

To make things easier, I've broken the PR into separate commits. If you want to check all the changes, I strongly recommend checking the commits sequentially.

Pay attention to commit messages

I have separate the commit messages meaningfully: the name in brackets help to identify the scope of the commit changes.

For instance:

  • if you want to check all commit where documentation was changed then check the commits with docs in brackets.
  • if you want to check commits for database resources check the commits with dbaas in brackets.

For each reviewer I suggest the following flow of review:

  • Check out commits with your area of interest: craas, dbaas, mks, secretmanager, vpc, iam, docs
  • Optionally check out provider and deps commits - that is core changes, which change way to configure provider or relate to dependencies updates (f.e. Go upgrade)

@sel-bukharov sel-bukharov force-pushed the major_release branch 6 times, most recently from 9f15e93 to 7f14a8f Compare November 25, 2024 05:22
@sel-bukharov sel-bukharov changed the title Major release Change configuration of provider Nov 25, 2024
@sel-bukharov sel-bukharov marked this pull request as ready for review November 25, 2024 07:23
@sel-bukharov sel-bukharov force-pushed the major_release branch 2 times, most recently from ade24ba to 70f027f Compare November 25, 2024 08:19
@shlykov shlykov requested review from shlykov and Icerzack November 25, 2024 10:34
milkrage
milkrage previously approved these changes Nov 27, 2024
T-Sh
T-Sh previously approved these changes Nov 27, 2024
T-Sh
T-Sh previously approved these changes Nov 29, 2024
milkrage
milkrage previously approved these changes Nov 29, 2024
@sel-bukharov sel-bukharov merged commit 9810b35 into master Dec 2, 2024
8 checks passed
@sel-bukharov sel-bukharov deleted the major_release branch December 2, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants