-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change configuration of provider #313
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sel-bukharov
force-pushed
the
major_release
branch
6 times, most recently
from
November 25, 2024 05:22
9f15e93
to
7f14a8f
Compare
sel-bukharov
force-pushed
the
major_release
branch
2 times, most recently
from
November 25, 2024 08:19
ade24ba
to
70f027f
Compare
sel-bukharov
force-pushed
the
major_release
branch
from
November 25, 2024 14:21
70f027f
to
2caf9a8
Compare
Icerzack
reviewed
Nov 25, 2024
sel-bukharov
force-pushed
the
major_release
branch
from
November 26, 2024 04:43
f59bf9b
to
aec58c8
Compare
sel-bukharov
force-pushed
the
major_release
branch
2 times, most recently
from
November 26, 2024 09:28
ab71bd1
to
c6aec50
Compare
sel-bukharov
force-pushed
the
major_release
branch
from
November 26, 2024 12:04
c6aec50
to
0c1e73c
Compare
milkrage
previously approved these changes
Nov 27, 2024
T-Sh
previously approved these changes
Nov 27, 2024
sel-bukharov
force-pushed
the
major_release
branch
from
November 28, 2024 13:22
0c1e73c
to
6687400
Compare
sel-bukharov
force-pushed
the
major_release
branch
from
November 29, 2024 10:34
6687400
to
961255e
Compare
T-Sh
previously approved these changes
Nov 29, 2024
milkrage
previously approved these changes
Nov 29, 2024
sel-bukharov
force-pushed
the
major_release
branch
from
December 2, 2024 05:29
961255e
to
bbbb260
Compare
TawR1024
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed
In this PR we change way to configure provider:
auth_url
andauth_region
are now required to configure providerSEL_REGION
andSEL_PROJECT_ID
env variables are renamed toINFRA_REGION
andINFRA_PROJECT_ID
respectivelyIn addition, resources which was deprecated long time ago was permanently removed from provider:
selectel_vpc_role_v2
selectel_vpc_token_v2
selectel_vpc_user_v2
selectel_vpc_vrrp_subnet_v2
selectel_vpc_crossregion_subnet_v2
Last but not least: changes such as updating deps and bumping Go version with updating necessary documentation (changelog, readme).
How to review changes
To make things easier, I've broken the PR into separate commits. If you want to check all the changes, I strongly recommend checking the commits sequentially.
Pay attention to commit messages
I have separate the commit messages meaningfully: the name in brackets help to identify the scope of the commit changes.
For instance:
docs
in brackets.dbaas
in brackets.For each reviewer I suggest the following flow of review:
craas
,dbaas
,mks
,secretmanager
,vpc
,iam
,docs
provider
anddeps
commits - that is core changes, which change way to configure provider or relate to dependencies updates (f.e. Go upgrade)