refactor: moved "filter" & "name" to const

selectel · Apr 2, 2024 · 492a8aa · 492a8aa
1 parent f7270f0
commit 492a8aa
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/internal/selprovider/constants.go b/internal/selprovider/constants.go
@@ -3,6 +3,8 @@ package selprovider
 const (
 	domainsOptionLimit  = "limit"
 	domainsOptionOffset = "offset"
+	domainsOptionFilter = "filter"
+	domainsOptionName   = "name"
 
 	defaultDomainsLimit  = "1000"
 	defaultDomainsOffset = "0"

diff --git a/internal/selprovider/rrset_fetcher.go b/internal/selprovider/rrset_fetcher.go
@@ -72,7 +72,7 @@ func (r *rrSetFetcher) getRRSetForUpdateDeletion(
 	}
 
 	domainRrSets, err := r.fetchRecords(ctx, client, resultZone.ID, map[string]string{
-		"name": change.DNSName,
+		domainsOptionName: change.DNSName,
 	})
 	if err != nil {
 		return nil, nil, err

diff --git a/internal/selprovider/zone_fetcher.go b/internal/selprovider/zone_fetcher.go
@@ -35,7 +35,7 @@ func (z *zoneFetcher) zones(ctx context.Context, client domains.DNSClient[domain
 	// send one request per filter
 	for _, filter := range z.domainFilter.Filters {
 		zones, err := z.fetchZones(ctx, client, map[string]string{
-			"filter": filter,
+			domainsOptionFilter: filter,
 		})
 		if err != nil {
 			return nil, err