refactor: merge sovran into core lib #924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisradek
reviewed
Apr 1, 2024
examples/E2E-73/android/app/src/main/java/com/analyticsreactnativee2e73/MainApplication.kt
Outdated
Show resolved
Hide resolved
chrisradek
reviewed
Apr 1, 2024
chrisradek
reviewed
Apr 1, 2024
chrisradek
reviewed
Apr 1, 2024
There was a problem hiding this comment.
Overall looks good, had a few minor comments.
Also wondering, do we still need to mock Sovran here:
analytics-react-native/packages/shared/__mocks__/react-native.ts
Lines 36 to 40 in 7160d3d
No need for that anymore. It's part of the methods that I removed altogether |
BREAKING CHANGE: @segment/sovran-react-native is now deprecated. Remove from your dependencies. All functionality is now rolled in the core package. Required changes: - Remove `@segment/sovran-react-native` from your dependencies. - iOS: If you are using `trackDeeplinks` or `setAnonymousId` from native you'll need to update the imports to ```diff - #import <segment_analytics_react_native-Swift.h> + #import "SegmentAnalyticsReactNative-Swift.h" ``` fix: remove test logs fix: remove sovran as dependency on all plugins fix: pr fixes fix: remove buildjson
chrisradek
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: @segment/sovran-react-native is now deprecated. Remove from your dependencies. All functionality is now rolled in the core package.
Required changes:
Remove
@segment/sovran-react-nativefrom your dependencies.iOS: If you are using
trackDeeplinksorsetAnonymousIdfrom native you'll need to update the imports to