-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consent plugin updates and test cases #894
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscb
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
really good test coverage! looks great!
oscb
pushed a commit
that referenced
this pull request
Dec 13, 2023
oscb
pushed a commit
that referenced
this pull request
Dec 15, 2023
## @segment/analytics-react-native [2.18.0-beta.1](https://github.com/segmentio/analytics-react-native/compare/@segment/analytics-react-native-v2.17.0...@segment/analytics-react-native-v2.18.0-beta.1) (2023-12-15) ### Features * add support for hasUnmappedDestinations ([#905](#905)) ([545d596](545d596)) * consent plugin updates and test cases ([#894](#894)) ([ff1d332](ff1d332)) * RN 0.72 Upgrade ([03f13a1](03f13a1)) ### Dependencies * **@segment/sovran-react-native:** upgraded to 1.1.0-beta.1
oscb
pushed a commit
that referenced
this pull request
Dec 15, 2023
## @segment/analytics-react-native [2.18.0](https://github.com/segmentio/analytics-react-native/compare/@segment/analytics-react-native-v2.17.0...@segment/analytics-react-native-v2.18.0) (2023-12-15) ### Features * add support for hasUnmappedDestinations ([#905](#905)) ([545d596](545d596)) * consent plugin updates and test cases ([#894](#894)) ([ff1d332](ff1d332)) * RN 0.72 Upgrade ([03f13a1](03f13a1)) ### Dependencies * **@segment/sovran-react-native:** upgraded to 1.1.0
oscb
pushed a commit
that referenced
this pull request
Dec 15, 2023
## @segment/analytics-react-native [2.18.0-beta.1](https://github.com/segmentio/analytics-react-native/compare/@segment/analytics-react-native-v2.17.0...@segment/analytics-react-native-v2.18.0-beta.1) (2023-12-15) ### Features * add support for hasUnmappedDestinations ([#905](#905)) ([545d596](545d596)) * consent plugin updates and test cases ([#894](#894)) ([ff1d332](ff1d332)) * RN 0.72 Upgrade ([03f13a1](03f13a1))
oscb
pushed a commit
that referenced
this pull request
Dec 15, 2023
## @segment/analytics-react-native [2.18.0-beta.1](https://github.com/segmentio/analytics-react-native/compare/@segment/analytics-react-native-v2.17.0...@segment/analytics-react-native-v2.18.0-beta.1) (2023-12-15) ### Features * add support for hasUnmappedDestinations ([#905](#905)) ([545d596](545d596)) * consent plugin updates and test cases ([#894](#894)) ([ff1d332](ff1d332)) * RN 0.72 Upgrade ([03f13a1](03f13a1)) ### Dependencies * **@segment/sovran-react-native:** upgraded to 1.1.0-beta.1
oscb
pushed a commit
that referenced
this pull request
Feb 1, 2024
## @segment/analytics-react-native [2.18.0](https://github.com/segmentio/analytics-react-native/compare/@segment/analytics-react-native-v2.17.0...@segment/analytics-react-native-v2.18.0) (2024-02-01) ### Features * add support for hasUnmappedDestinations ([#905](#905)) ([545d596](545d596)) * consent plugin updates and test cases ([#894](#894)) ([ff1d332](ff1d332)) * RN 0.72 Upgrade ([03f13a1](03f13a1)) ### Bug Fixes * remove circular dependency in ConsentPlugin ([71e7eae](71e7eae)) ### Dependencies * **@segment/sovran-react-native:** upgraded to 1.1.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work is direct derivative of @bsneed's https://github.com/segment-integrations/analytics-swift-consent/tree/main which in turn is a derivative of consent test cases document.
This patch follows advisory of @bsneed and mirrors his work closely - so any amendments that follow will likely be applicable to both repositories.