Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consent plugin updates and test cases #894

Merged
merged 3 commits into from
Dec 1, 2023
Merged

Consent plugin updates and test cases #894

merged 3 commits into from
Dec 1, 2023

Conversation

zikaari
Copy link
Contributor

@zikaari zikaari commented Nov 6, 2023

This work is direct derivative of @bsneed's https://github.com/segment-integrations/analytics-swift-consent/tree/main which in turn is a derivative of consent test cases document.

This patch follows advisory of @bsneed and mirrors his work closely - so any amendments that follow will likely be applicable to both repositories.

@zikaari zikaari requested review from oscb and chrisradek November 6, 2023 17:39
Copy link
Contributor

@oscb oscb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really good test coverage! looks great!

@zikaari zikaari merged commit 1ab0660 into master Dec 1, 2023
6 checks passed
@zikaari zikaari deleted the consent_part_2 branch December 1, 2023 17:58
oscb pushed a commit that referenced this pull request Dec 15, 2023
## @segment/analytics-react-native [2.18.0-beta.1](https://github.com/segmentio/analytics-react-native/compare/@segment/analytics-react-native-v2.17.0...@segment/analytics-react-native-v2.18.0-beta.1) (2023-12-15)

### Features

* add support for hasUnmappedDestinations ([#905](#905)) ([545d596](545d596))
* consent plugin updates and test cases ([#894](#894)) ([ff1d332](ff1d332))
* RN 0.72 Upgrade ([03f13a1](03f13a1))

### Dependencies

* **@segment/sovran-react-native:** upgraded to 1.1.0-beta.1
oscb pushed a commit that referenced this pull request Dec 15, 2023
## @segment/analytics-react-native [2.18.0](https://github.com/segmentio/analytics-react-native/compare/@segment/analytics-react-native-v2.17.0...@segment/analytics-react-native-v2.18.0) (2023-12-15)

### Features

* add support for hasUnmappedDestinations ([#905](#905)) ([545d596](545d596))
* consent plugin updates and test cases ([#894](#894)) ([ff1d332](ff1d332))
* RN 0.72 Upgrade ([03f13a1](03f13a1))

### Dependencies

* **@segment/sovran-react-native:** upgraded to 1.1.0
oscb pushed a commit that referenced this pull request Dec 15, 2023
## @segment/analytics-react-native [2.18.0-beta.1](https://github.com/segmentio/analytics-react-native/compare/@segment/analytics-react-native-v2.17.0...@segment/analytics-react-native-v2.18.0-beta.1) (2023-12-15)

### Features

* add support for hasUnmappedDestinations ([#905](#905)) ([545d596](545d596))
* consent plugin updates and test cases ([#894](#894)) ([ff1d332](ff1d332))
* RN 0.72 Upgrade ([03f13a1](03f13a1))
oscb pushed a commit that referenced this pull request Dec 15, 2023
## @segment/analytics-react-native [2.18.0-beta.1](https://github.com/segmentio/analytics-react-native/compare/@segment/analytics-react-native-v2.17.0...@segment/analytics-react-native-v2.18.0-beta.1) (2023-12-15)

### Features

* add support for hasUnmappedDestinations ([#905](#905)) ([545d596](545d596))
* consent plugin updates and test cases ([#894](#894)) ([ff1d332](ff1d332))
* RN 0.72 Upgrade ([03f13a1](03f13a1))

### Dependencies

* **@segment/sovran-react-native:** upgraded to 1.1.0-beta.1
oscb pushed a commit that referenced this pull request Feb 1, 2024
## @segment/analytics-react-native [2.18.0](https://github.com/segmentio/analytics-react-native/compare/@segment/analytics-react-native-v2.17.0...@segment/analytics-react-native-v2.18.0) (2024-02-01)

### Features

* add support for hasUnmappedDestinations ([#905](#905)) ([545d596](545d596))
* consent plugin updates and test cases ([#894](#894)) ([ff1d332](ff1d332))
* RN 0.72 Upgrade ([03f13a1](03f13a1))

### Bug Fixes

* remove circular dependency in ConsentPlugin ([71e7eae](71e7eae))

### Dependencies

* **@segment/sovran-react-native:** upgraded to 1.1.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants