Add consent management and support for onetrust cmp #882

zikaari · 2023-09-20T00:40:17Z

This patch implements the work laid out in mobile consent management SDD.

A great starting point for reviewers to check compliance with the SDD is OneTrust.test.ts file.

packages/core/src/plugins/ConsentPlugin.ts

oscb

I think this looks really good!
Left a few comments. Just 2 major things;

RxJS, can we simplify?
Storage, let's make sure this can work offline too

Left a conversation there about the behavior that libraries should take when the consent information is not available. Might need some slight changes.

packages/core/src/plugins/ConsentPlugin.ts

packages/plugins/plugin-onetrust/src/OTProvider.ts

oscb · 2023-09-22T18:23:10Z

🚢 I already approved but saw the Android Integration tests failing.
I don't see anything in your changes that could be impacting those tests, might be just a blip in Detox. The only other possibility I can think of is if Detox has an issue with NPM 18 as I see you bumped this value, although I would be surprised if it was only impacting Android.

I just put a retry run. Let's see if that clears it. Else might require some investigation.

chrisradek

Overall looks good to me! (Though I'm not very familiar with this codebase)

packages/plugins/plugin-onetrust/README.md

chrisradek · 2023-09-22T19:46:23Z

packages/plugins/plugin-onetrust/package.json

@@ -0,0 +1,85 @@
+{
+  "name": "@segment/analytics-react-native-plugin-onetrust",
+  "version": "0.0.0",


What version will this end up getting published as?

Depends on what we decide while running yarn version command - whether we want to release it as 1.0.0 or 1.0.0-rc or 1.0.0-alpha etc. I don't have knowledge on what our stance is around shipping this entire feature.

Seems like for Kotlin it is being released as 1.0.x right now
I think if we change the commit message to feat: consent-management ti will release it properly

silesky · 2023-09-27T22:44:55Z

packages/core/src/plugins/ConsentPlugin.ts

@@ -0,0 +1,134 @@
+import {
+  Plugin,
+  type SegmentClient,


I didn't know about this syntax!

silesky · 2023-09-27T22:46:15Z

packages/plugins/plugin-onetrust/jest.config.js

+  },
+  moduleFileExtensions: ['ts', 'tsx', 'js', 'jsx', 'json', 'node'],
+  modulePaths: [compilerOptions.baseUrl],
+  moduleNameMapper: pathsToModuleNameMapper(compilerOptions.paths),


Didn't know about this helper!

silesky · 2023-09-27T22:47:25Z

packages/plugins/plugin-onetrust/src/OneTrust.ts

+import { ConsentPlugin } from '@segment/analytics-react-native';
+
+import { OTPublishersNativeSDK, OTCategoryConsentProvider } from './OTProvider';
+


Very clean!

silesky

LGTM
Looks very clean 🚀

## [@segment/analytics-react-native-v2.17.0](https://github.com/segmentio/analytics-react-native/compare/@segment/analytics-react-native-v2.16.1...@segment/analytics-react-native-v2.17.0) (2023-10-20) ### Features * add consent management and support for onetrust cmp ([#882](#882)) ([375684f](375684f)) ### Bug Fixes * add unknown option to current state ([#887](#887)) ([a0a3b0d](a0a3b0d)) * change content type to json ([#885](#885)) ([e8ddeb4](e8ddeb4))

## @segment/analytics-react-native-plugin-onetrust-v1.0.0 (2023-10-20) ### Features * add consent management and support for onetrust cmp ([#882](#882)) ([375684f](375684f))

Add consent management and support for onetrust cmp

2ff1894

zikaari requested review from oscb and alanjcharles September 20, 2023 00:40

CI: change node from 16 to 18

cd31d73

zikaari commented Sep 20, 2023

View reviewed changes

packages/core/src/plugins/ConsentPlugin.ts Outdated Show resolved Hide resolved

zikaari commented Sep 20, 2023

View reviewed changes

packages/core/src/plugins/ConsentPlugin.ts Outdated Show resolved Hide resolved

zikaari commented Sep 20, 2023

View reviewed changes

packages/core/src/plugins/ConsentPlugin.ts Show resolved Hide resolved

oscb suggested changes Sep 20, 2023

View reviewed changes

Review feedback

df1b61a

zikaari marked this pull request as ready for review September 22, 2023 00:08

zikaari requested a review from oscb September 22, 2023 00:08

oscb approved these changes Sep 22, 2023

View reviewed changes

Revert node version

3841995

chrisradek reviewed Sep 22, 2023

View reviewed changes

update license and description

5dd1ca3

silesky reviewed Sep 27, 2023

View reviewed changes

packages/core/src/plugins/ConsentPlugin.ts

@@ -0,0 +1,134 @@

import {

Plugin,

type SegmentClient,

Copy link

silesky Sep 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know about this syntax!

silesky reviewed Sep 27, 2023

View reviewed changes

silesky requested changes Sep 27, 2023

View reviewed changes

silesky approved these changes Sep 27, 2023

View reviewed changes

oscb merged commit 375684f into master Oct 2, 2023
4 checks passed

oscb deleted the consent_management branch October 2, 2023 20:21

oscb pushed a commit that referenced this pull request Oct 20, 2023

chore(release): 1.0.0 [skip ci]

e3ff066

## @segment/analytics-react-native-plugin-onetrust-v1.0.0 (2023-10-20) ### Features * add consent management and support for onetrust cmp ([#882](#882)) ([375684f](375684f))

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add consent management and support for onetrust cmp #882

Add consent management and support for onetrust cmp #882

zikaari commented Sep 20, 2023 •

edited

Loading

oscb left a comment

oscb commented Sep 22, 2023

chrisradek left a comment

chrisradek Sep 22, 2023

zikaari Sep 22, 2023

oscb Oct 2, 2023

silesky Sep 27, 2023

silesky Sep 27, 2023

silesky Sep 27, 2023

silesky left a comment

		import { ConsentPlugin } from '@segment/analytics-react-native';

		import { OTPublishersNativeSDK, OTCategoryConsentProvider } from './OTProvider';

Add consent management and support for onetrust cmp #882

Add consent management and support for onetrust cmp #882

Conversation

zikaari commented Sep 20, 2023 • edited Loading

oscb left a comment

Choose a reason for hiding this comment

oscb commented Sep 22, 2023

chrisradek left a comment

Choose a reason for hiding this comment

chrisradek Sep 22, 2023

Choose a reason for hiding this comment

zikaari Sep 22, 2023

Choose a reason for hiding this comment

oscb Oct 2, 2023

Choose a reason for hiding this comment

silesky Sep 27, 2023

Choose a reason for hiding this comment

silesky Sep 27, 2023

Choose a reason for hiding this comment

silesky Sep 27, 2023

Choose a reason for hiding this comment

silesky left a comment

Choose a reason for hiding this comment

zikaari commented Sep 20, 2023 •

edited

Loading