Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: advertising id being sent for Android application installed events using analytics-react-native-plugin-advertsing-id #1015

Merged
merged 3 commits into from
Oct 23, 2024
Merged

fix: advertising id being sent for Android application installed events using analytics-react-native-plugin-advertsing-id #1015

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a971498
fix: to show 'Queue restoration timeout' only once
Oct 22, 2024
867e52a
fix: advertising id being sent for Android application installed events
Oct 23, 2024
d49d6d6
Merge branch 'segmentio:master' into master
thesunita Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions packages/plugins/plugin-advertising-id/src/AdvertisingIdPlugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import {
getNativeModule,
ErrorType,
SegmentError,
SegmentEvent
} from '@segment/analytics-react-native';

import { Platform, NativeModule } from 'react-native';
Expand All @@ -15,6 +16,8 @@ type AdvertisingIDNativeModule = NativeModule & {

export class AdvertisingIdPlugin extends Plugin {
type = PluginType.enrichment;
queuedEvents: SegmentEvent[] = [];
advertisingId?: string = undefined;

configure(analytics: SegmentClient): void {
if (Platform.OS !== 'android') {
Expand All @@ -34,6 +37,7 @@ export class AdvertisingIdPlugin extends Plugin {
'LimitAdTrackingEnabled (Google Play Services) is enabled'
);
} else {
this.advertisingId = id
void this.setContext(id);
}
})
Expand All @@ -48,6 +52,16 @@ export class AdvertisingIdPlugin extends Plugin {
});
}

execute(event: SegmentEvent){

if (this.advertisingId === undefined) {
this.queuedEvents.push(event);
}else{
return event;
}
return;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does it means in this context to return undefined? What if there's other plugin that is meant to be executed after this plugin? Does this means that the other plugin won't get anything to process? Will the other plugin indeed eventually get something once we execute process for this event?

Comment on lines +57 to +62
Copy link

@cgadam cgadam Oct 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: a more clear way for this if could also be:

if (this.advertisingId === undefined) {
  this.queuedEvents.push(event);
  return;
}
return event;

}

async setContext(id: string): Promise<void> {
try {
await this.analytics?.context.set({
Expand All @@ -56,6 +70,7 @@ export class AdvertisingIdPlugin extends Plugin {
adTrackingEnabled: true,
},
});
this.sendQueued();
} catch (error) {
const message = 'AdvertisingID failed to set context';
this.analytics?.reportInternalError(
Expand All @@ -64,4 +79,11 @@ export class AdvertisingIdPlugin extends Plugin {
this.analytics?.logger.warn(`${message}: ${JSON.stringify(error)}`);
}
}

sendQueued() {
this.queuedEvents.forEach(event => {
void this.analytics?.process(event);
});
this.queuedEvents = [];
}
}
Loading