Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop Testimonial & Success Stories Containers #81

Merged
merged 2 commits into from
Feb 17, 2024

Conversation

vishwaikon
Copy link
Contributor

Purpose

The purpose is to fix #50 by developing homepage components with tailwind

Goals

Rebuilding the AntD Home layout using Tailwind CSS ensuring responsiveness.

Approach

NA

Screenshots

image
image

Checklist

  • [X ] This PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
  • [X ] I have read and understood the development best practices guidelines ( http://bit.ly/sef-best-practices )
  • [X ] My code follows the style guidelines of this project
  • [X ] I have performed a self-review of my own code
  • [ X] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Related PRs

#79

Test environment

NA

Learning

NA

@vishwaikon vishwaikon marked this pull request as ready for review February 15, 2024 18:52
@@ -27,7 +26,7 @@
font-weight: bold
}

.homePageSecondaryButton{
/* .homePageSecondaryButton{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove this commented css @vishwaikon. Check whether the other CSS classes are also being used if not we can remove the CSS file altogether

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anjula-sack, Sure I'll. Thought of keeping a few CSS classes till the remaining parts are completed to prevent conflicts.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah we can remove the unused css.

Copy link
Member

@anjula-sack anjula-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! @vishwaikon

@anjula-sack anjula-sack merged commit e2df9be into sef-global:main Feb 17, 2024
2 checks passed
@vishwaikon vishwaikon deleted the testingbranch branch February 17, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate from ant design to tailwind css
2 participants