Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of the Google OAuth on the frontend #80

Merged
merged 28 commits into from
Feb 11, 2024

Conversation

mayura-andrew
Copy link
Member

Purpose

The purpose of this PR is to fix #77

Goals

Implemented Google Sign-in button in the LoginModal Component to enhance user experience and ease of login.

Approach

Integrated Google's OAuth API to handle authentication and incorporated the Google Sign-In button into the LoginModal component. Users can now sign in using their Google accounts.

Screenshots

Screenshot_20240208_222432

Checklist

  • This PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
  • I have read and understood the development best practices guidelines ( http://bit.ly/sef-best-practices )
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Related PRs

Test environment

Web Browser - Vivaldi 6.5.3206.59 stable
NodeJs - v20.10.0

Learning

Learned about Google's OAuth implementation in frontend. This feature will help users to login quickly using their Google account credentials, improving the overall user experience.

@@ -140,6 +145,31 @@ const LoginModal: React.FC<LoginModalProps> = ({ handleClose }) => {
>
Login
</button>
<div
className="my-1 flex items-center before:mt-0.2 before:flex-1 before:border-t before:border-neutral-300 after:mt-0.5 after:flex-1 after:border-t after:border-neutral-300"
style={{ margin: '0' }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
style={{ margin: '0' }}

m-0

@anjula-sack
Copy link
Member

Hi @mayura-andrew, can you add the requested change?

@mayura-andrew
Copy link
Member Author

Year sure I will it tonight

Copy link
Member

@anjula-sack anjula-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! @mayura-andrew

@anjula-sack anjula-sack merged commit e7f5112 into sef-global:main Feb 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implementation of the Google OAuth on the frontend
2 participants