Create the footer using tailwind css #76
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in external CSS stylesheet were replaced with Tailwind CSS classes. The code to import the external stylesheet was commented to prevent style conflicts.
…acilitate using same color code throughout the website, dark moderate blue: darkmod-blue #3dd17C and desaturated blue: desat-blue #6D7893
anjula-sack
reviewed
Feb 1, 2024
There was a problem hiding this comment.
Good job! @vishwaikon I added some comments. Also there are lint fails. Run npm run lint to check them. Also keep the PR titles short.
| Let`s Rethink Education! | ||
| </div> | ||
| <div className="footerSecondaryTitle font-sans text-base text-darkmod-blue font-normal"> | ||
| {' '} |
Comment on lines
23
to
51
| <svg | ||
| className="w-6" | ||
| xmlns="http://www.w3.org/2000/svg" | ||
| aria-label="Twitter" | ||
| role="img" | ||
| viewBox="0 0 512 512" | ||
| > | ||
| <rect width="512" height="512" rx="15%" fill="#1da1f2" /> | ||
| <path | ||
| fill="#ffffff" | ||
| d="M437 152a72 72 0 01-40 12a72 72 0 0032-40a72 72 0 01-45 17a72 72 0 00-122 65a200 200 0 01-145-74a72 72 0 0022 94a72 72 0 01-32-7a72 72 0 0056 69a72 72 0 01-32 1a72 72 0 0067 50a200 200 0 01-105 29a200 200 0 00309-179a200 200 0 0035-37" | ||
| /> | ||
| </svg> | ||
| </a> | ||
| </div> | ||
|
|
||
| <div className="facebook w-7 h-7 rounded flex justify-center items-center bg-[#3B5999] ml-2 mb-2"> | ||
| <a href="https://www.facebook.com/sustainableeducationfoundation/"> | ||
| <svg | ||
| className="w-7" | ||
| viewBox="0 -6 512 512" | ||
| xmlns="http://www.w3.org/2000/svg" | ||
| > | ||
| <path fill="#475a96" d="M0 0h512v500H0z" /> | ||
| <path | ||
| d="M375.717 112.553H138.283c-8.137 0-14.73 6.594-14.73 14.73v237.434c0 8.135 6.594 14.73 14.73 14.73h127.826V276.092h-34.781v-40.28h34.781v-29.705c0-34.473 21.055-53.244 51.807-53.244 14.73 0 27.391 1.097 31.08 1.587v36.026l-21.328.01c-16.725 0-19.963 7.947-19.963 19.609v25.717h39.887l-5.193 40.28h-34.693v103.355h68.012c8.135 0 14.73-6.596 14.73-14.73V127.283c-.001-8.137-6.596-14.73-14.731-14.73z" | ||
| fill="#ffffff" | ||
| /> | ||
| </svg> |
There was a problem hiding this comment.
Let's create separate components for svgs so we can manage them easily. create a folder called assets->svgs and keep the svgs there.
There was a problem hiding this comment.
Sure, I will create
| </Text> | ||
| </Col> | ||
| </Row> | ||
| </a>{' '} |
There was a problem hiding this comment.
Suggested change
| </a>{' '} | |
| </a> |
anjula-sack
changed the title
| </a>{' '} | ||
| </div> | ||
| </div> | ||
| </> | ||
| ); | ||
| export default FooterComponent; |
There was a problem hiding this comment.
add EOF here after line number 313
|
Hi, @mayura-andrew , I fixed the ESLint errors, but the ESLint check still fails. |
@vishwaikon Run npm run lint and see the lint errors should be shown there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…in external CSS stylesheet were replaced with Tailwind CSS classes. The code to import the external stylesheet was commented to prevent style conflicts.
Purpose
The purpose of this PR is to develop the footer of the website and replace the Antd styles with Tailwind CSS which is a part of fixing issue #50.
Goals
Tailwind classes were used to enhance efficiency and readability and the structure.
Approach
The CSS flexbox was used and Tailwind CSS classes were used to achieve the Antd styles. The code to import the external stylesheet was commented to prevent conflicts in styles and to be used if required.
Screenshots
Checklist
Related PRs
Test environment
Learning