Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix category dropdown of mentor application to match with endpoint update #64

Merged

Conversation

Madhawa97
Copy link
Member

Purpose

The purpose of this PR is to fix #63

Goals

The category dropdown of mentor application needs to be updated to comply with the backend endpoint changes introduced with this pull request.

Approach

Update the code to use category.uuid instead of category.id.

Screenshots

Checklist

  • This PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
  • I have read and understood the development best practices guidelines ( http://bit.ly/sef-best-practices )
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Related PRs

PR #83 on scholarx/backend

Test environment

Learning

@Madhawa97
Copy link
Member Author

Madhawa97 commented Jan 3, 2024

Also the documentation needs to be updated to have,

{
    "categories": [
        {
            "category": "Data Science",
            "id": "95ba00c0-8173-43c4-9573-6b481b4085e2"
        },
        {
            "category": "Random Category",
            "id": "fe7ca629-4f5e-440a-86cb-d54f8b98ec5f"
        },
        {
            "category": "Computer Science",
            "id": "fef68adb-e710-4d9e-8772-dc4905885088"
        }
    ],
    "message": "All Categories found"
}

@anjula-sack anjula-sack merged commit b3433db into sef-global:main Jan 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix category dropdown of mentor application
2 participants