Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mentor registration page #60

Merged
merged 7 commits into from
Dec 23, 2023
Merged

Conversation

Madhawa97
Copy link
Member

Purpose

The purpose of this PR is to fix #16

Goals

This PR addresses the issue of creating a mentor applications view. The implementation closely matches the provided mockup, providing mentors with a platform to apply as a mentor.

Approach

  • Basic React components required for the feature have been set up.
  • The layout and design of the mentee profile public view have been implemented, following the provided mockup.
  • Necessary components and assets have been integrated to achieve the desired functionality and visual appearance.
  • Responsiveness and compatibility across different devices and screen sizes have been ensured.

Screenshots

Step 01:
image

Step 02:
image

Step 03:
image

Checklist

  • This PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
  • I have read and understood the development best practices guidelines ( http://bit.ly/sef-best-practices )
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Related PRs

Test environment

Learning

@Madhawa97 Madhawa97 requested a review from anjula-sack December 1, 2023 20:46
Comment on lines 88 to 92
{user !== null ? (
<Link to="/mentor-registration">
<Button className={styles.loginButton}>Become a Mentor</Button>
</Link>
) : null}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be visible without login. when they try to sign up we check whether they are logged in or not.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sending in

Copy link
Member

@anjula-sack anjula-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! @Madhawa97

@anjula-sack anjula-sack merged commit aad1502 into sef-global:main Dec 23, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement the mentor application view
2 participants