Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add User Login component #42

Closed
wants to merge 8 commits into from
Closed

Add User Login component #42

wants to merge 8 commits into from

Conversation

RandilaP
Copy link
Contributor

@RandilaP RandilaP commented Aug 5, 2023

Purpose

The purpose of this PR is to fix #5

Goals

  • Add User Login component to the repository

Approach

Screenshots

image

Checklist

  • This PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
  • I have read and understood the development best practices guidelines ( http://bit.ly/sef-best-practices )
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Related PRs

Test environment

Learning

@RandilaP
Copy link
Contributor Author

RandilaP commented Aug 5, 2023

@anjula-sack @kumuditha-udayanga @Piumal1999 Could you please review this

@anjula-sack
Copy link
Member

Good job! @RandilaP can you resolve the conflicts?

@anjula-sack
Copy link
Member

Any updates @RandilaP?

@RandilaP
Copy link
Contributor Author

@anjula-sack @kumuditha-udayanga @Piumal1999 @jayasanka-sack Could you please review this

@RandilaP
Copy link
Contributor Author

@anjula-sack @kumuditha-udayanga Could you please review this

anjula-sack
anjula-sack reviewed Sep 11, 2023
View reviewed changes
src/components/UserLogin/UserLogin.stories.tsx Outdated

type Story = StoryObj<typeof meta>;

export const EmptyList: Story = {};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RandilaP You need to write a sample story for this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anjula-sack Can you give me an example

@anjula-sack
Copy link
Member

This has been done by #59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anjula-sack anjula-sack anjula-sack left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement the user login view
2 participants
@RandilaP @anjula-sack