Add support for target keys #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardogama
force-pushed
the
feature/target-keys
branch
6 times, most recently
from
47a2a56 to
df80ca2
Compare
ricardogama
force-pushed
the
feature/target-keys
branch
3 times, most recently
from
1429800 to
9aea9d8
Compare
Remove node 0.10 from travis configuration.
ricardogama
force-pushed
the
feature/target-keys
branch
from
9aea9d8 to
f1983f9
Compare
|
I've read here #9 (comment) that this cannot be merged until the next version of bookshelf has been released. To which version where you refering to? It seems that there have been some new versions between this dates. |
|
I guess that I was assuming bookshelf/bookshelf#1419 was going to be merged, without that fix this feature is incomplete. Although it might be outdated you can use that Bookshelf's PR branch and this one and try the feature out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for target keys that was introduced on bookshelf/bookshelf#1397.