feat: add pausable functionality to Core and Prover #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariocao
force-pushed
the
feat/pausable
branch
from
02ff795 to
13367cc
Compare
Thomasvdam
reviewed
Jan 14, 2025
mariocao
force-pushed
the
feat/pausable
branch
from
13367cc to
31a4b49
Compare
Thomasvdam
approved these changes
Jan 14, 2025
gluax
approved these changes
Jan 14, 2025
| bytes32[] calldata merkleProof | ||
| ) external view override returns (bool, address) { | ||
| // Only return true if we have a stored batch at this height | ||
| BatchData memory batch = _batches[batchHeight]; |
There was a problem hiding this comment.
Is batchHeight the height the batch was posted or the batchNumber? Paranoid thought we can't ever have multiple batches per a height right?
There was a problem hiding this comment.
Or did I forget and those are the same thing :x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add support for pausing the SedaCoreV1 and Secp256k1Prover contracts.
Explanation of Changes
PausableUpgradeablecontractwhenNotPausedmodifiersTesting