-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add data request incentives #83
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code logic looks good to me.
I'm going to nit on the comments as the auditors want comment coverage.
Some of the comments describe what the code is doing. Which should only be done if something complex is happening, which I don't think most of this is.
Comments should describe why the code is doing what it's doing. This helps maintain readability and understanding more than stating what something is doing.
The comments on functions and types are good though :).
Comments looking much better!! |
|
||
function postRequest( | ||
SedaDataTypes.RequestInputs calldata inputs, | ||
uint256 requestFee, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing to fix here but we should really have a wrapper or something to simplify the 3 fees and the rest of the inputs properties. (even if the user is overpaying, they'll get it refunded.)
Motivation
This PR implements fee management functionality in the SEDA Core contract, allowing for:
Explanation of Changes
The changes introduce several key components:
postResult
functionincreaseFees
function to allow updating fees for pending requestsRequestDetails
struct to efficiently store fee-related dataTesting
The changes are covered by comprehensive tests:
Related PRs and Issues
Closes #77
Closes #78
Closes #79
Closes #80