Tally requests with missing reveals #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hacheigriega
force-pushed
the
hy/missing-reveals
branch
from
9cfd82d to
a269136
Compare
hacheigriega
force-pushed
the
hy/incentive
branch
from
e70a899 to
7cc82fe
Compare
hacheigriega
force-pushed
the
hy/missing-reveals
branch
from
a269136 to
2eedbd8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now tally requests that have timed out due to missing reveals. Median or mode is calculated the same way as before with whatever reveals that have been collected. However, the threshold for consensus is now 2/3 of the replication factor, instead of the number of collected reveals.
In addition, the filter functions have been fully separated from the tally keeper type for modularity. The filter and tally process has also been slightly refactored for clarity.