Gas metering for filters #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thomasvdam
reviewed
Dec 17, 2024
hacheigriega
force-pushed
the
hy/improve-tests
branch
2 times, most recently
from
2f6bc9e to
035b083
Compare
mariocao
reviewed
Dec 17, 2024
mariocao
reviewed
Dec 17, 2024
hacheigriega
force-pushed
the
hy/filter-gas
branch
from
b2ec120 to
bf967f3
Compare
hacheigriega
force-pushed
the
hy/filter-gas
branch
from
bf967f3 to
53cbd3d
Compare
mariocao
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of Changes
Adding gas metering for filters as described in Issue #449.
The gas used amount is constant for a given filter type and replication factor regardless of whether the filter returned an error or not. If the filter was not applied at all, the gas used is zero.
The gas used towards filtering is subtracted from the gas limit we feed into the tally VM.
In addition, the tally gas used amount is now the sum of the gas used by the tally VM and the gas used by the filter.
Testing
Added checks to the existing filter tests
Related PRs and Issues
Closes #449